Skip to content

Commit 94d0704

Browse files
chadlittlechadlittle
committed
Add objectheaders to new View
Summary: This adds the 'PHUIObjectBox' to nearly every place that should get it. I need to comb through Diffusion a little more. I've left Differential mostly alone, but may decide to do it anyways this weekend. I'm sure I missed something else, but these are easy enough to update. Test Plan: tested each new layout. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7162
1 parent 0318cad commit 94d0704

File tree

61 files changed

+526
-365
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

61 files changed

+526
-365
lines changed

‎resources/sprite/gradients/lightblue-header.png

-1 Bytes
Loading

‎resources/sprite/manifest/gradient.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"gradient-lightblue-header" : {
3535
"name" : "gradient-lightblue-header",
3636
"rule" : ".gradient-lightblue-header",
37-
"hash" : "b838d2eb15f9b620e82b4da240bf464a"
37+
"hash" : "e7753a6ce63c6822a559266eef9e255b"
3838
},
3939
"gradient-menu-label" : {
4040
"name" : "gradient-menu-label",

‎src/__celerity_resource_map__.php

Lines changed: 83 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -632,8 +632,8 @@
632632
),
633633
'/rsrc/image/sprite-gradient.png' =>
634634
array(
635-
'hash' => 'c6c42387e625948e683d9d8c62ea1b7f',
636-
'uri' => '/res/c6c42387/rsrc/image/sprite-gradient.png',
635+
'hash' => '1f0306b0ca281b1e5b96de0096269f1d',
636+
'uri' => '/res/1f0306b0/rsrc/image/sprite-gradient.png',
637637
'disk' => '/rsrc/image/sprite-gradient.png',
638638
'type' => 'png',
639639
),
@@ -890,7 +890,7 @@
890890
),
891891
'aphront-panel-view-css' =>
892892
array(
893-
'uri' => '/res/915e0a4b/rsrc/css/aphront/panel-view.css',
893+
'uri' => '/res/70d7011b/rsrc/css/aphront/panel-view.css',
894894
'type' => 'css',
895895
'requires' =>
896896
array(
@@ -1017,7 +1017,7 @@
10171017
),
10181018
'differential-changeset-view-css' =>
10191019
array(
1020-
'uri' => '/res/b1c98bac/rsrc/css/application/differential/changeset-view.css',
1020+
'uri' => '/res/5fd9d5c0/rsrc/css/application/differential/changeset-view.css',
10211021
'type' => 'css',
10221022
'requires' =>
10231023
array(
@@ -1026,7 +1026,7 @@
10261026
),
10271027
'differential-core-view-css' =>
10281028
array(
1029-
'uri' => '/res/85fe5117/rsrc/css/application/differential/core.css',
1029+
'uri' => '/res/7db1595a/rsrc/css/application/differential/core.css',
10301030
'type' => 'css',
10311031
'requires' =>
10321032
array(
@@ -3018,7 +3018,7 @@
30183018
),
30193019
'phabricator-action-list-view-css' =>
30203020
array(
3021-
'uri' => '/res/c6219563/rsrc/css/layout/phabricator-action-list-view.css',
3021+
'uri' => '/res/ade71822/rsrc/css/layout/phabricator-action-list-view.css',
30223022
'type' => 'css',
30233023
'requires' =>
30243024
array(
@@ -3371,7 +3371,7 @@
33713371
),
33723372
'phabricator-property-list-view-css' =>
33733373
array(
3374-
'uri' => '/res/abc1bb1c/rsrc/css/layout/phabricator-property-list-view.css',
3374+
'uri' => '/res/7835f74e/rsrc/css/layout/phabricator-property-list-view.css',
33753375
'type' => 'css',
33763376
'requires' =>
33773377
array(
@@ -3474,7 +3474,7 @@
34743474
),
34753475
'phabricator-timeline-view-css' =>
34763476
array(
3477-
'uri' => '/res/79b6d385/rsrc/css/layout/phabricator-timeline-view.css',
3477+
'uri' => '/res/09567421/rsrc/css/layout/phabricator-timeline-view.css',
34783478
'type' => 'css',
34793479
'requires' =>
34803480
array(
@@ -3656,7 +3656,7 @@
36563656
),
36573657
'pholio-css' =>
36583658
array(
3659-
'uri' => '/res/cfdf017f/rsrc/css/application/pholio/pholio.css',
3659+
'uri' => '/res/e64264c9/rsrc/css/application/pholio/pholio.css',
36603660
'type' => 'css',
36613661
'requires' =>
36623662
array(
@@ -3742,7 +3742,7 @@
37423742
),
37433743
'phui-document-view-css' =>
37443744
array(
3745-
'uri' => '/res/7928af2d/rsrc/css/phui/phui-document.css',
3745+
'uri' => '/res/40e39942/rsrc/css/phui/phui-document.css',
37463746
'type' => 'css',
37473747
'requires' =>
37483748
array(
@@ -3769,7 +3769,7 @@
37693769
),
37703770
'phui-form-view-css' =>
37713771
array(
3772-
'uri' => '/res/d87bdbeb/rsrc/css/phui/phui-form-view.css',
3772+
'uri' => '/res/157ddd8b/rsrc/css/phui/phui-form-view.css',
37733773
'type' => 'css',
37743774
'requires' =>
37753775
array(
@@ -3778,7 +3778,7 @@
37783778
),
37793779
'phui-header-view-css' =>
37803780
array(
3781-
'uri' => '/res/2a60156a/rsrc/css/phui/phui-header-view.css',
3781+
'uri' => '/res/94208bd6/rsrc/css/phui/phui-header-view.css',
37823782
'type' => 'css',
37833783
'requires' =>
37843784
array(
@@ -3803,6 +3803,15 @@
38033803
),
38043804
'disk' => '/rsrc/css/phui/phui-list.css',
38053805
),
3806+
'phui-object-box-css' =>
3807+
array(
3808+
'uri' => '/res/3c1129d2/rsrc/css/phui/phui-object-box.css',
3809+
'type' => 'css',
3810+
'requires' =>
3811+
array(
3812+
),
3813+
'disk' => '/rsrc/css/phui/phui-object-box.css',
3814+
),
38063815
'phui-object-item-list-view-css' =>
38073816
array(
38083817
'uri' => '/res/71f7f081/rsrc/css/phui/phui-object-item-list-view.css',
@@ -3877,7 +3886,7 @@
38773886
),
38783887
'ponder-comment-table-css' =>
38793888
array(
3880-
'uri' => '/res/fd114c83/rsrc/css/application/ponder/comments.css',
3889+
'uri' => '/res/4aa4b865/rsrc/css/application/ponder/comments.css',
38813890
'type' => 'css',
38823891
'requires' =>
38833892
array(
@@ -4084,7 +4093,7 @@
40844093
),
40854094
'sprite-gradient-css' =>
40864095
array(
4087-
'uri' => '/res/08c64fb3/rsrc/css/sprite-gradient.css',
4096+
'uri' => '/res/e31d9063/rsrc/css/sprite-gradient.css',
40884097
'type' => 'css',
40894098
'requires' =>
40904099
array(
@@ -4175,7 +4184,7 @@
41754184
), array(
41764185
'packages' =>
41774186
array(
4178-
'd72a9463' =>
4187+
'9d16ff0b' =>
41794188
array(
41804189
'name' => 'core.pkg.css',
41814190
'symbols' =>
@@ -4224,7 +4233,7 @@
42244233
41 => 'phabricator-tag-view-css',
42254234
42 => 'phui-list-view-css',
42264235
),
4227-
'uri' => '/res/pkg/d72a9463/core.pkg.css',
4236+
'uri' => '/res/pkg/9d16ff0b/core.pkg.css',
42284237
'type' => 'css',
42294238
),
42304239
'64eeda79' =>
@@ -4286,7 +4295,7 @@
42864295
'uri' => '/res/pkg/4ccfeb47/darkconsole.pkg.js',
42874296
'type' => 'js',
42884297
),
4289-
'44bfe40c' =>
4298+
'b55e602f' =>
42904299
array(
42914300
'name' => 'differential.pkg.css',
42924301
'symbols' =>
@@ -4305,7 +4314,7 @@
43054314
11 => 'differential-local-commits-view-css',
43064315
12 => 'inline-comment-summary-css',
43074316
),
4308-
'uri' => '/res/pkg/44bfe40c/differential.pkg.css',
4317+
'uri' => '/res/pkg/b55e602f/differential.pkg.css',
43094318
'type' => 'css',
43104319
),
43114320
'5e9e5c4e' =>
@@ -4416,30 +4425,30 @@
44164425
),
44174426
'reverse' =>
44184427
array(
4419-
'aphront-dialog-view-css' => 'd72a9463',
4420-
'aphront-error-view-css' => 'd72a9463',
4421-
'aphront-list-filter-view-css' => 'd72a9463',
4422-
'aphront-pager-view-css' => 'd72a9463',
4423-
'aphront-panel-view-css' => 'd72a9463',
4424-
'aphront-table-view-css' => 'd72a9463',
4425-
'aphront-tokenizer-control-css' => 'd72a9463',
4426-
'aphront-tooltip-css' => 'd72a9463',
4427-
'aphront-typeahead-control-css' => 'd72a9463',
4428-
'differential-changeset-view-css' => '44bfe40c',
4429-
'differential-core-view-css' => '44bfe40c',
4428+
'aphront-dialog-view-css' => '9d16ff0b',
4429+
'aphront-error-view-css' => '9d16ff0b',
4430+
'aphront-list-filter-view-css' => '9d16ff0b',
4431+
'aphront-pager-view-css' => '9d16ff0b',
4432+
'aphront-panel-view-css' => '9d16ff0b',
4433+
'aphront-table-view-css' => '9d16ff0b',
4434+
'aphront-tokenizer-control-css' => '9d16ff0b',
4435+
'aphront-tooltip-css' => '9d16ff0b',
4436+
'aphront-typeahead-control-css' => '9d16ff0b',
4437+
'differential-changeset-view-css' => 'b55e602f',
4438+
'differential-core-view-css' => 'b55e602f',
44304439
'differential-inline-comment-editor' => '5e9e5c4e',
4431-
'differential-local-commits-view-css' => '44bfe40c',
4432-
'differential-results-table-css' => '44bfe40c',
4433-
'differential-revision-add-comment-css' => '44bfe40c',
4434-
'differential-revision-comment-css' => '44bfe40c',
4435-
'differential-revision-comment-list-css' => '44bfe40c',
4436-
'differential-revision-history-css' => '44bfe40c',
4437-
'differential-revision-list-css' => '44bfe40c',
4438-
'differential-table-of-contents-css' => '44bfe40c',
4440+
'differential-local-commits-view-css' => 'b55e602f',
4441+
'differential-results-table-css' => 'b55e602f',
4442+
'differential-revision-add-comment-css' => 'b55e602f',
4443+
'differential-revision-comment-css' => 'b55e602f',
4444+
'differential-revision-comment-list-css' => 'b55e602f',
4445+
'differential-revision-history-css' => 'b55e602f',
4446+
'differential-revision-list-css' => 'b55e602f',
4447+
'differential-table-of-contents-css' => 'b55e602f',
44394448
'diffusion-commit-view-css' => 'c8ce2d88',
44404449
'diffusion-icons-css' => 'c8ce2d88',
4441-
'global-drag-and-drop-css' => 'd72a9463',
4442-
'inline-comment-summary-css' => '44bfe40c',
4450+
'global-drag-and-drop-css' => '9d16ff0b',
4451+
'inline-comment-summary-css' => 'b55e602f',
44434452
'javelin-aphlict' => '64eeda79',
44444453
'javelin-behavior' => '9564fa17',
44454454
'javelin-behavior-aphlict-dropdown' => '64eeda79',
@@ -4513,56 +4522,56 @@
45134522
'javelin-util' => '9564fa17',
45144523
'javelin-vector' => '9564fa17',
45154524
'javelin-workflow' => '9564fa17',
4516-
'lightbox-attachment-css' => 'd72a9463',
4525+
'lightbox-attachment-css' => '9d16ff0b',
45174526
'maniphest-task-summary-css' => '49898640',
4518-
'phabricator-action-list-view-css' => 'd72a9463',
4519-
'phabricator-application-launch-view-css' => 'd72a9463',
4527+
'phabricator-action-list-view-css' => '9d16ff0b',
4528+
'phabricator-application-launch-view-css' => '9d16ff0b',
45204529
'phabricator-busy' => '64eeda79',
4521-
'phabricator-content-source-view-css' => '44bfe40c',
4522-
'phabricator-core-css' => 'd72a9463',
4523-
'phabricator-crumbs-view-css' => 'd72a9463',
4530+
'phabricator-content-source-view-css' => 'b55e602f',
4531+
'phabricator-core-css' => '9d16ff0b',
4532+
'phabricator-crumbs-view-css' => '9d16ff0b',
45244533
'phabricator-drag-and-drop-file-upload' => '5e9e5c4e',
45254534
'phabricator-dropdown-menu' => '64eeda79',
45264535
'phabricator-file-upload' => '64eeda79',
4527-
'phabricator-filetree-view-css' => 'd72a9463',
4528-
'phabricator-flag-css' => 'd72a9463',
4536+
'phabricator-filetree-view-css' => '9d16ff0b',
4537+
'phabricator-flag-css' => '9d16ff0b',
45294538
'phabricator-hovercard' => '64eeda79',
4530-
'phabricator-jump-nav' => 'd72a9463',
4539+
'phabricator-jump-nav' => '9d16ff0b',
45314540
'phabricator-keyboard-shortcut' => '64eeda79',
45324541
'phabricator-keyboard-shortcut-manager' => '64eeda79',
4533-
'phabricator-main-menu-view' => 'd72a9463',
4542+
'phabricator-main-menu-view' => '9d16ff0b',
45344543
'phabricator-menu-item' => '64eeda79',
4535-
'phabricator-nav-view-css' => 'd72a9463',
4544+
'phabricator-nav-view-css' => '9d16ff0b',
45364545
'phabricator-notification' => '64eeda79',
4537-
'phabricator-notification-css' => 'd72a9463',
4538-
'phabricator-notification-menu-css' => 'd72a9463',
4539-
'phabricator-object-selector-css' => '44bfe40c',
4546+
'phabricator-notification-css' => '9d16ff0b',
4547+
'phabricator-notification-menu-css' => '9d16ff0b',
4548+
'phabricator-object-selector-css' => 'b55e602f',
45404549
'phabricator-phtize' => '64eeda79',
45414550
'phabricator-prefab' => '64eeda79',
45424551
'phabricator-project-tag-css' => '49898640',
4543-
'phabricator-property-list-view-css' => 'd72a9463',
4544-
'phabricator-remarkup-css' => 'd72a9463',
4552+
'phabricator-property-list-view-css' => '9d16ff0b',
4553+
'phabricator-remarkup-css' => '9d16ff0b',
45454554
'phabricator-shaped-request' => '5e9e5c4e',
4546-
'phabricator-side-menu-view-css' => 'd72a9463',
4547-
'phabricator-standard-page-view' => 'd72a9463',
4548-
'phabricator-tag-view-css' => 'd72a9463',
4555+
'phabricator-side-menu-view-css' => '9d16ff0b',
4556+
'phabricator-standard-page-view' => '9d16ff0b',
4557+
'phabricator-tag-view-css' => '9d16ff0b',
45494558
'phabricator-textareautils' => '64eeda79',
45504559
'phabricator-tooltip' => '64eeda79',
4551-
'phabricator-transaction-view-css' => 'd72a9463',
4552-
'phabricator-zindex-css' => 'd72a9463',
4553-
'phui-button-css' => 'd72a9463',
4554-
'phui-form-css' => 'd72a9463',
4555-
'phui-form-view-css' => 'd72a9463',
4556-
'phui-header-view-css' => 'd72a9463',
4557-
'phui-icon-view-css' => 'd72a9463',
4558-
'phui-list-view-css' => 'd72a9463',
4559-
'phui-object-item-list-view-css' => 'd72a9463',
4560-
'phui-spacing-css' => 'd72a9463',
4561-
'sprite-apps-large-css' => 'd72a9463',
4562-
'sprite-gradient-css' => 'd72a9463',
4563-
'sprite-icons-css' => 'd72a9463',
4564-
'sprite-menu-css' => 'd72a9463',
4565-
'sprite-status-css' => 'd72a9463',
4566-
'syntax-highlighting-css' => 'd72a9463',
4560+
'phabricator-transaction-view-css' => '9d16ff0b',
4561+
'phabricator-zindex-css' => '9d16ff0b',
4562+
'phui-button-css' => '9d16ff0b',
4563+
'phui-form-css' => '9d16ff0b',
4564+
'phui-form-view-css' => '9d16ff0b',
4565+
'phui-header-view-css' => '9d16ff0b',
4566+
'phui-icon-view-css' => '9d16ff0b',
4567+
'phui-list-view-css' => '9d16ff0b',
4568+
'phui-object-item-list-view-css' => '9d16ff0b',
4569+
'phui-spacing-css' => '9d16ff0b',
4570+
'sprite-apps-large-css' => '9d16ff0b',
4571+
'sprite-gradient-css' => '9d16ff0b',
4572+
'sprite-icons-css' => '9d16ff0b',
4573+
'sprite-menu-css' => '9d16ff0b',
4574+
'sprite-status-css' => '9d16ff0b',
4575+
'syntax-highlighting-css' => '9d16ff0b',
45674576
),
45684577
));

‎src/applications/config/controller/PhabricatorConfigAllController.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,10 @@ public function processRequest() {
7272
$version_property_list->addProperty($name, $hash);
7373
}
7474

75+
$object_box = id(new PHUIObjectBoxView())
76+
->setHeaderText(pht('Current Settings'))
77+
->addContent($version_property_list);
78+
7579
$phabricator_root = dirname(phutil_get_library_root('phabricator'));
7680
$version_path = $phabricator_root.'/conf/local/VERSION';
7781
if (Filesystem::pathExists($version_path)) {
@@ -84,7 +88,7 @@ public function processRequest() {
8488
$nav = $this->buildSideNavView();
8589
$nav->selectFilter('all/');
8690
$nav->setCrumbs($crumbs);
87-
$nav->appendChild($version_property_list);
91+
$nav->appendChild($object_box);
8892
$nav->appendChild($panel);
8993

9094

‎src/applications/countdown/controller/PhabricatorCountdownViewController.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,14 @@ public function processRequest() {
4747
$actions = $this->buildActionListView($countdown);
4848
$properties = $this->buildPropertyListView($countdown);
4949

50+
$object_box = id(new PHUIObjectBoxView())
51+
->setHeader($header)
52+
->addContent($actions)
53+
->addContent($properties);
54+
5055
$content = array(
5156
$crumbs,
52-
$header,
53-
$actions,
54-
$properties,
57+
$object_box,
5558
$countdown_view,
5659
);
5760

0 commit comments

Comments
 (0)