Add support for more granular sending of email in application transactions

Summary: Deploy on paste and macro for create stories, 'cuz those are boring emails. Fixes T3808.

Test Plan: made a paste and a macro. commented on 'em. verified i got mail on comments only.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, aran

Maniphest Tasks: T3808

Differential Revision: https://secure.phabricator.com/D6988

Author: bobtrahan

src/applications/conpherence/editor/ConpherenceEditor.php

@@ -322,7 +322,9 @@ protected function mergeTransactions(
     return parent::mergeTransactions($u, $v);
   }
 
-  protected function supportsMail() {
+  protected function shouldSendMail(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
     return true;
   }
 

src/applications/files/editor/PhabricatorFileEditor.php

@@ -36,7 +36,9 @@ protected function applyCustomExternalTransaction(
     PhabricatorApplicationTransaction $xaction) {
   }
 
-  protected function supportsMail() {
+  protected function shouldSendMail(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
     return true;
   }
 

src/applications/legalpad/editor/LegalpadDocumentEditor.php

@@ -122,7 +122,9 @@ protected function mergeTransactions(
 
 /* -(  Sending Mail  )------------------------------------------------------- */
 
-  protected function supportsMail() {
+  protected function shouldSendMail(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
     return true;
   }
 

src/applications/macro/editor/PhabricatorMacroEditor.php

@@ -78,7 +78,17 @@ protected function mergeTransactions(
     return parent::mergeTransactions($u, $v);
   }
 
-  protected function supportsMail() {
+  protected function shouldSendMail(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
+    foreach ($xactions as $xaction) {
+      switch ($xaction->getTransactionType()) {
+        case PhabricatorMacroTransactionType::TYPE_NAME;
+          return ($xaction->getOldValue() !== null);
+        default:
+          break;
+      }
+    }
     return true;
   }
 

src/applications/paste/editor/PhabricatorPasteEditor.php

@@ -100,7 +100,17 @@ protected function applyInitialEffects(
     }
   }
 
-  protected function supportsMail() {
+  protected function shouldSendMail(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
+    foreach ($xactions as $xaction) {
+      switch ($xaction->getTransactionType()) {
+        case PhabricatorPasteTransaction::TYPE_CREATE:
+          return false;
+        default:
+          break;
+      }
+    }
     return true;
   }
 

src/applications/pholio/editor/PholioMockEditor.php

@@ -288,7 +288,9 @@ protected function mergeTransactions(
     return parent::mergeTransactions($u, $v);
   }
 
-  protected function supportsMail() {
+  protected function shouldSendMail(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
     return true;
   }
 

src/applications/ponder/editor/PonderQuestionEditor.php

@@ -165,7 +165,9 @@ protected function shouldImplyCC(
     return parent::shouldImplyCC($object, $xaction);
   }
 
-  protected function supportsMail() {
+  protected function shouldSendMail(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
     return true;
   }
 

src/applications/releeph/editor/ReleephRequestTransactionalEditor.php

@@ -155,7 +155,9 @@ protected function filterTransactions(
     return parent::filterTransactions($object, $xactions);
   }
 
-  protected function supportsMail() {
+  protected function shouldSendMail(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
     return true;
   }
 

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

@@ -457,7 +457,7 @@ final public function applyTransactions(
     $this->loadHandles($xactions);
 
     $mail = null;
-    if ($this->supportsMail()) {
+    if ($this->shouldSendMail($object, $xactions)) {
       $mail = $this->sendMail($object, $xactions);
     }
 
@@ -1069,7 +1069,9 @@ protected function shouldImplyCC(
   /**
    * @task mail
    */
-  protected function supportsMail() {
+  protected function shouldSendMail(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
     return false;
   }