Add actions to mobile crumbs

Summary: Adds in the ActionList into Crumbs for mobile on many applications.

Test Plan: Tested each application except probably drydock since not sure how to test that. Also cleaned up Ponder a little.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5648

Author: chadlittle

src/applications/drydock/controller/DrydockLeaseViewController.php

@@ -39,6 +39,7 @@ public function processRequest() {
     $log_table->appendChild($pager);
 
     $crumbs = $this->buildApplicationCrumbs();
+    $crumbs->setActionList($actions);
     $crumbs->addCrumb(
       id(new PhabricatorCrumbView())
         ->setName($title)

src/applications/drydock/controller/DrydockResourceViewController.php

@@ -51,6 +51,7 @@ public function processRequest() {
     $log_table->appendChild($pager);
 
     $crumbs = $this->buildApplicationCrumbs();
+    $crumbs->setActionList($actions);
     $crumbs->addCrumb(
       id(new PhabricatorCrumbView())
         ->setName(pht('Resource %d', $resource->getID())));

src/applications/files/controller/PhabricatorFileInfoController.php

@@ -22,15 +22,7 @@ public function processRequest() {
     }
 
     $this->loadHandles(array($file->getAuthorPHID()));
-
     $phid = $file->getPHID();
-
-    $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName('F'.$file->getID())
-        ->setHref($this->getApplicationURI("/info/{$phid}/")));
-
     $header = id(new PhabricatorHeaderView())
       ->setHeader($file->getName());
 
@@ -45,6 +37,13 @@ public function processRequest() {
     $actions = $this->buildActionView($file);
     $properties = $this->buildPropertyView($file);
 
+    $crumbs = $this->buildApplicationCrumbs();
+    $crumbs->setActionList($actions);
+    $crumbs->addCrumb(
+      id(new PhabricatorCrumbView())
+        ->setName('F'.$file->getID())
+        ->setHref($this->getApplicationURI("/info/{$phid}/")));
+
     return $this->buildApplicationPage(
       array(
         $crumbs,

src/applications/macro/controller/PhabricatorMacroViewController.php

@@ -30,14 +30,15 @@ public function processRequest() {
       $macro->getPHID());
 
     $this->loadHandles($subscribers);
+    $actions = $this->buildActionView($macro);
 
     $crumbs = $this->buildApplicationCrumbs();
+    $crumbs->setActionList($actions);
     $crumbs->addCrumb(
       id(new PhabricatorCrumbView())
         ->setHref($this->getApplicationURI('/view/'.$macro->getID().'/'))
         ->setName($title_short));
 
-    $actions = $this->buildActionView($macro);
     $properties = $this->buildPropertyView($macro, $file, $subscribers);
 
     $xactions = id(new PhabricatorMacroTransactionQuery())

src/applications/paste/controller/PhabricatorPasteViewController.php

@@ -53,6 +53,7 @@ public function processRequest() {
     $source_code = $this->buildSourceCodeView($paste);
 
     $crumbs = $this->buildApplicationCrumbs($this->buildSideNavView())
+      ->setActionList($actions)
       ->addCrumb(
         id(new PhabricatorCrumbView())
           ->setName('P'.$paste->getID())

src/applications/pholio/controller/PholioMockViewController.php

@@ -85,6 +85,7 @@ public function processRequest() {
     $add_comment = $this->buildAddCommentView($mock);
 
     $crumbs = $this->buildApplicationCrumbs($this->buildSideNav());
+    $crumbs->setActionList($actions);
     $crumbs->addCrumb(
       id(new PhabricatorCrumbView())
         ->setName('M'.$mock->getID())

src/applications/phortune/controller/PhortuneAccountViewController.php

@@ -47,6 +47,8 @@ public function processRequest() {
           ->setHref('#')
           ->setDisabled(true));
 
+    $crumbs->setActionList($actions);
+
     $properties = id(new PhabricatorPropertyListView())
       ->setObject($account)
       ->setUser($user);

src/applications/phortune/controller/PhortuneProductViewController.php

@@ -23,16 +23,6 @@ public function processRequest() {
 
     $title = pht('Product: %s', $product->getProductName());
 
-    $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Products'))
-        ->setHref($this->getApplicationURI('product/')));
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('#%d', $product->getID()))
-        ->setHref($request->getRequestURI()));
-
     $header = id(new PhabricatorHeaderView())
       ->setHeader($product->getProductName());
 
@@ -46,6 +36,17 @@ public function processRequest() {
           ->setHref($edit_uri)
           ->setIcon('edit'));
 
+    $crumbs = $this->buildApplicationCrumbs();
+    $crumbs->setActionList($actions);
+    $crumbs->addCrumb(
+      id(new PhabricatorCrumbView())
+        ->setName(pht('Products'))
+        ->setHref($this->getApplicationURI('product/')));
+    $crumbs->addCrumb(
+      id(new PhabricatorCrumbView())
+        ->setName(pht('#%d', $product->getID()))
+        ->setHref($request->getRequestURI()));
+
     $properties = id(new PhabricatorPropertyListView())
       ->setUser($user)
       ->addProperty(pht('Type'), $product->getTypeName())

src/applications/phriction/controller/PhrictionDocumentController.php

@@ -224,14 +224,15 @@ public function processRequest() {
 
     $children = $this->renderDocumentChildren($slug);
 
+    $actions = $this->buildActionView($user, $document);
+
     $crumbs = $this->buildApplicationCrumbs();
+    $crumbs->setActionList($actions);
     $crumb_views = $this->renderBreadcrumbs($slug);
     foreach ($crumb_views as $view) {
       $crumbs->addCrumb($view);
     }
 
-    $actions = $this->buildActionView($user, $document);
-
     $header = id(new PhabricatorHeaderView())
       ->setHeader($page_title);
 

src/applications/ponder/controller/PonderController.php

@@ -5,7 +5,7 @@ abstract class PonderController extends PhabricatorController {
   public function buildStandardPageResponse($view, array $data) {
 
     $page = $this->buildStandardPageView();
-    $page->setApplicationName('Ponder!');
+    $page->setApplicationName(pht('Ponder!'));
     $page->setBaseURI('/ponder/');
     $page->setTitle(idx($data, 'title'));
     $page->setGlyph("\xE2\x97\xB3");
@@ -20,24 +20,24 @@ protected function buildSideNavView(PonderQuestion $question = null) {
     $side_nav = new AphrontSideNavFilterView();
     $side_nav->setBaseURI(new PhutilURI($this->getApplicationURI()));
 
-    if ($question && $question->getID()) {
-      $side_nav->addFilter(
-        null,
-        'Q'.$question->getID(),
-        'Q'.$question->getID());
-    }
+    $side_nav->addLabel(pht('Questions'));
+    $side_nav->addFilter('feed', pht('All Questions'));
+    $side_nav->addFilter('questions', pht('Your Questions'));
+    $side_nav->addFilter('answers', pht('Your Answers'));
 
-    $side_nav->addLabel('Create');
-    $side_nav->addFilter('question/ask', 'Ask a Question');
-
-    $side_nav->addLabel('Questions');
-    $side_nav->addFilter('feed', 'All Questions');
+    return $side_nav;
+  }
 
-    $side_nav->addLabel('User');
-    $side_nav->addFilter('questions', 'Your Questions');
-    $side_nav->addFilter('answers', 'Your Answers');
+  public function buildApplicationCrumbs() {
+    $crumbs = parent::buildApplicationCrumbs();
+    $crumbs
+      ->addAction(
+        id(new PhabricatorMenuItemView())
+          ->setName(pht('New Question'))
+          ->setHref('question/ask')
+          ->setIcon('create'));
 
-    return $side_nav;
+    return $crumbs;
   }
 
 }

src/applications/ponder/controller/PonderFeedController.php

@@ -80,6 +80,7 @@ public function processRequest() {
       array(
         'device'  => true,
         'title'   => $title,
+        'dust'    => true,
       ));
   }
 

src/applications/ponder/controller/PonderQuestionViewController.php

@@ -64,15 +64,22 @@ public function processRequest() {
       ->setActionURI("/ponder/answer/add/");
 
     $header = id(new PhabricatorHeaderView())
-      ->setObjectName('Q'.$question->getID())
       ->setHeader($question->getTitle());
 
     $actions = $this->buildActionListView($question);
     $properties = $this->buildPropertyListView($question, $subscribers);
 
+    $crumbs = $this->buildApplicationCrumbs($this->buildSideNavView());
+    $crumbs->setActionList($actions);
+    $crumbs->addCrumb(
+        id(new PhabricatorCrumbView())
+          ->setName('Q'.$this->questionID)
+          ->setHref('/Q'.$this->questionID));
+
     $nav = $this->buildSideNavView($question);
     $nav->appendChild(
       array(
+        $crumbs,
         $header,
         $actions,
         $properties,

src/view/layout/PhabricatorCrumbsView.php

@@ -30,7 +30,7 @@ public function render() {
     require_celerity_resource('phabricator-crumbs-view-css');
 
     $action_view = null;
-    if ($this->actions) {
+    if (($this->actions) || ($this->actionListID)) {
       $actions = array();
       foreach ($this->actions as $action) {
         $icon = null;