[CMake] Parameterize MODULE and SHARED in add_clang_library().

llvm-svn: 199902

Author: chapuni

clang/CMakeLists.txt

@@ -275,7 +275,8 @@ function(clang_tablegen)
 endfunction(clang_tablegen)
 
 macro(add_clang_library name)
-  llvm_process_sources(srcs ${ARGN})
+  cmake_parse_arguments(ARG "MODULE;SHARED;STATIC" "" "" ${ARGN})
+  llvm_process_sources(srcs ${ARG_UNPARSED_ARGUMENTS})
   if(MSVC_IDE OR XCODE)
     # Add public headers
     file(RELATIVE_PATH lib_path
@@ -298,9 +299,9 @@ macro(add_clang_library name)
       set(srcs ${srcs} ${headers} ${tds})
     endif()
   endif(MSVC_IDE OR XCODE)
-  if (MODULE)
+  if (ARG_MODULE)
     set(libkind MODULE)
-  elseif (SHARED_LIBRARY)
+  elseif (ARG_SHARED)
     set(libkind SHARED)
   else()
     set(libkind)
@@ -316,7 +317,7 @@ macro(add_clang_library name)
   target_link_libraries( ${name} ${LLVM_COMMON_LIBS} )
   link_system_libs( ${name} )
 
-  if ((SHARED_LIBRARY OR MODULE) AND LLVM_EXPORTED_SYMBOL_FILE)
+  if ((ARG_SHARED OR ARG_MODULE) AND LLVM_EXPORTED_SYMBOL_FILE)
     add_llvm_symbol_exports( ${name} ${LLVM_EXPORTED_SYMBOL_FILE} )
   endif()
 

clang/examples/PrintFunctionNames/CMakeLists.txt

@@ -1,5 +1,3 @@
-set(MODULE TRUE)
-
 set( LLVM_LINK_COMPONENTS
   Support
   )
@@ -15,7 +13,7 @@ if( NOT WIN32 ) # Win32 mangles symbols differently, and
   endif()
 endif()
 
-add_clang_library(PrintFunctionNames PrintFunctionNames.cpp)
+add_clang_library(PrintFunctionNames MODULE PrintFunctionNames.cpp)
 
 add_dependencies(PrintFunctionNames
   ClangAttrClasses

clang/examples/analyzer-plugin/CMakeLists.txt

@@ -1,10 +1,8 @@
-set(MODULE TRUE)
-
 set(LLVM_LINK_COMPONENTS
   Support
   )
 
-add_clang_library(SampleAnalyzerPlugin MainCallChecker.cpp)
+add_clang_library(SampleAnalyzerPlugin MODULE MainCallChecker.cpp)
 
 add_dependencies(SampleAnalyzerPlugin
   ClangAttrClasses

clang/tools/libclang/CMakeLists.txt

@@ -73,8 +73,7 @@ if(MSVC)
 endif()
 
 if( LLVM_ENABLE_PIC )
-  set(SHARED_LIBRARY TRUE)
-  add_clang_library(libclang ${SOURCES})
+  add_clang_library(libclang SHARED ${SOURCES})
   target_link_libraries(libclang ${LIBRARIES})
   add_dependencies(libclang ${GENERATED_HEADERS} clang-headers)