Fix the clang -Werror build after r217152 by flagging a polymorphically used but statically owned hierarchy with a protected base dtor and final classes to satisfy -Wnon-virtual-dtor

llvm-svn: 217167

Author: dwblaikie

clang/include/clang/ASTMatchers/Dynamic/VariantValue.h

@@ -110,6 +110,9 @@ class VariantMatcher {
         ast_matchers::internal::VariadicOperatorFunction Func,
         ArrayRef<VariantMatcher> InnerMatchers) const;
 
+  protected:
+    ~MatcherOps() {}
+
   private:
     ast_type_traits::ASTNodeKind NodeKind;
   };
@@ -218,7 +221,7 @@ class VariantMatcher {
 };
 
 template <typename T>
-struct VariantMatcher::TypedMatcherOps : VariantMatcher::MatcherOps {
+struct VariantMatcher::TypedMatcherOps final : VariantMatcher::MatcherOps {
   TypedMatcherOps()
       : MatcherOps(ast_type_traits::ASTNodeKind::getFromNodeKind<T>()) {}
   typedef ast_matchers::internal::Matcher<T> MatcherT;