Skip to content

Commit de23ba0

Browse files
author
epriestley
committedMar 12, 2016
Fix a minor issue in Nuance which could cause the trigger daemon to poll too often
Summary: Ref T10537. Currently, when you have at least two cursors, the daemon can poll too frequently when processing the last source because it never hits the end-of-list condition. Test Plan: - Ran `bin/phd debug trigger`. - Observed huge volumes of output before change as triggers fired as fast as possible. - Observed reasonable poll frequency after change. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10537 Differential Revision: https://secure.phabricator.com/D15464
1 parent 5df5f33 commit de23ba0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ private function updateNuanceImportCursors() {
411411
}
412412

413413
// If we haven't loaded sources yet, load them first.
414-
if (!$this->nuanceSources) {
414+
if (!$this->nuanceSources && !$this->nuanceCursors) {
415415
$this->anyNuanceData = false;
416416

417417
$sources = id(new NuanceSourceQuery())

0 commit comments

Comments
 (0)
Failed to load comments.