Skip to content

Commit 13c0c3b

Browse files
author
epriestley
committedApr 8, 2015
Fix "To: Unknown Object" on outbound Maniphest mail with no owner
Summary: Fixes T7778. This was likely caused by removing an `array_filter()` somewhere in the course of T7731, but I'd rather have the code be more correct. Test Plan: Sent mail on a task with no owner. - Before patch: unknown recipient. - After patch: expected recipients. Reviewers: btrahan, joshuaspence Reviewed By: joshuaspence Subscribers: epriestley Maniphest Tasks: T7778 Differential Revision: https://secure.phabricator.com/D12320
1 parent 4783c39 commit 13c0c3b

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed
 

‎src/applications/maniphest/editor/ManiphestTransactionEditor.php

+8-4
Original file line numberDiff line numberDiff line change
@@ -386,10 +386,14 @@ protected function getMailThreadID(PhabricatorLiskDAO $object) {
386386
}
387387

388388
protected function getMailTo(PhabricatorLiskDAO $object) {
389-
return array(
390-
$object->getOwnerPHID(),
391-
$this->getActingAsPHID(),
392-
);
389+
$phids = array();
390+
391+
if ($object->getOwnerPHID()) {
392+
$phids[] = $object->getOwnerPHID();
393+
}
394+
$phids[] = $this->getActingAsPHID();
395+
396+
return $phids;
393397
}
394398

395399
public function getMailTagsMap() {

0 commit comments

Comments
 (0)
Failed to load comments.