500 Error caused by RecalculateAccesses:"Delete action needs at least one condition" When create a new repo

[makisekuris]

Description

try to create a new personal repository . Gitea returns a 500 error. the logs show that

gitea  | 2025/06/09 09:41:32 .../context_response.go:70:HTML() [D] Template: repo/create
gitea  | 2025/06/09 09:41:32 ...eb/routing/logger.go:102:func1() [I] router: completed GET /repo/create for 162.248.73.193:0, 200 OK in 18.4ms @ repo/repo.go:152(repo.Create)
gitea  | 2025/06/09 09:41:36 ...eb/routing/logger.go:68:func1() [I] router: polling   GET /user/events for 162.248.73.193:0, elapsed 3366.1ms @ events/events.go:18(events.Events)
gitea  | 2025/06/09 09:41:43 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/events for 162.248.73.193:0, 200 OK in 9815.6ms @ events/events.go:18(events.Events)
gitea  | 2025/06/09 09:41:43 ...ers/web/repo/repo.go:217:handleCreateError() [E] CreatePost: RecalculateAccesses: delete old accesses: Delete action needs at least one condition
gitea  | 2025/06/09 09:41:43 .../context_response.go:70:HTML() [D] Template: status/500
gitea  | 2025/06/09 09:41:43 ...eb/routing/logger.go:102:func1() [I] router: completed POST /repo/create for 162.248.73.193:0, 500 Internal Server Error in 22.6ms @ repo/repo.go:222(repo.CreatePost)
gitea  | 2025/06/09 09:41:45 .../context_response.go:70:HTML() [D] Template: user/dashboard/dashboard

i tried to update gitea to latest version / use another account / check the database but no way to resolve for it.

i guess it is maybe the problem came from database ? how can i further to check this problem?

Gitea Version

1.23.8

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

Git Version

No response

Operating System

No response

How are you running Gitea?

I run it from docker compose on a local instance

Database

MySQL/MariaDB

[lunny]

What MySQL engine does your Gitea instance use?

[wxiaoguang]

What MySQL engine does your Gitea instance use?

Isn't the error returned by XORM? It doesn't seem related to database. (see below)

[wxiaoguang]

The bug is in createRepositoryInDB -> RecalculateAccesses -> refreshAccesses -> DeleteByBean(ctx, &Access{RepoID: repo.ID})

It is literally wrong: the "repo" is manually constructed and there is no "repo.ID"

(see below)

[wxiaoguang]

The bug is in createRepositoryInDB -> RecalculateAccesses -> refreshAccesses -> DeleteByBean(ctx, &Access{RepoID: repo.ID})

It is literally wrong: the "repo" is manually constructed and there is no "repo.ID"

Maybe XORM expects that the "Insert" should fill the "ID", but the user's database doesn't? @makisekuris can you show your database type / database engine, and the "repository" table's "create sql"?

[lunny]

The codebase is based on the release/v1.23 branch, and the relevant function is CreateRepositoryByExample. The Insert call is expected to populate the Repository object with a valid database ID upon successful insertion. However, this behavior appears weird, and I haven’t been able to reproduce the issue in my local environment.

[makisekuris]

What MySQL engine does your Gitea instance use?

at now it using

MySQL 8.0.21
InnoDB
CHARACTER SET utf8mb4 COLLATE utf8mb4_0900_as_cs

it about a month ago I migrate it from mysql 5.7 to mysql 8.0.21 , so recently i built a new Mysql in docker for

MySQL 5.7
InnoDB
CHARACTER SET utf8mb4 COLLATE utf8mb4_bin

to try but it also get this error

Besides migrate i recall another operation what changed the config is was adding OAuth2 authentication，but it hasn't be used except for some experimental

this error is appeared in version 1.22.3 when i noticed. I upgraded to 1.23.8 attempt to resolve it, but the problem still persists.

The bug is in createRepositoryInDB -> RecalculateAccesses -> refreshAccesses -> DeleteByBean(ctx, &Access{RepoID: repo.ID})
It is literally wrong: the "repo" is manually constructed and there is no "repo.ID"

Maybe XORM expects that the "Insert" should fill the "ID", but the user's database doesn't? @makisekuris can you show your database type / database engine, and the "repository" table's "create sql"?

in MYSQL 8.0.21 the repository is

CREATE TABLE `repository` (
  `id` bigint DEFAULT NULL,
  `owner_id` bigint DEFAULT NULL,
  `owner_name` varchar(255) COLLATE utf8mb4_0900_as_cs DEFAULT NULL,
  `lower_name` varchar(255) COLLATE utf8mb4_0900_as_cs DEFAULT NULL,
  `name` varchar(255) COLLATE utf8mb4_0900_as_cs DEFAULT NULL,
  `description` text COLLATE utf8mb4_0900_as_cs,
  `website` varchar(2048) COLLATE utf8mb4_0900_as_cs DEFAULT NULL,
  `original_service_type` int DEFAULT NULL,
  `original_url` varchar(2048) COLLATE utf8mb4_0900_as_cs DEFAULT NULL,
  `default_branch` varchar(255) COLLATE utf8mb4_0900_as_cs DEFAULT NULL,
  `num_watches` int DEFAULT NULL,
  `num_stars` int DEFAULT NULL,
  `num_forks` int DEFAULT NULL,
  `num_issues` int DEFAULT NULL,
  `num_closed_issues` int DEFAULT NULL,
  `num_pulls` int DEFAULT NULL,
  `num_closed_pulls` int DEFAULT NULL,
  `num_milestones` int DEFAULT NULL,
  `num_closed_milestones` int DEFAULT NULL,
  `num_projects` int DEFAULT NULL,
  `num_closed_projects` int DEFAULT NULL,
  `is_private` tinyint(1) DEFAULT NULL,
  `is_empty` tinyint(1) DEFAULT NULL,
  `is_archived` tinyint(1) DEFAULT NULL,
  `is_mirror` tinyint(1) DEFAULT NULL,
  `status` int DEFAULT NULL,
  `is_fork` tinyint(1) DEFAULT NULL,
  `fork_id` bigint DEFAULT NULL,
  `is_template` tinyint(1) DEFAULT NULL,
  `template_id` bigint DEFAULT NULL,
  `size` bigint DEFAULT NULL,
  `is_fsck_enabled` tinyint(1) DEFAULT NULL,
  `close_issues_via_commit_in_any_branch` tinyint(1) DEFAULT NULL,
  `topics` text COLLATE utf8mb4_0900_as_cs,
  `trust_model` int DEFAULT NULL,
  `avatar` varchar(64) COLLATE utf8mb4_0900_as_cs DEFAULT NULL,
  `created_unix` bigint DEFAULT NULL,
  `updated_unix` bigint DEFAULT NULL,
  `num_action_runs` int DEFAULT NULL,
  `num_closed_action_runs` int DEFAULT NULL,
  `archived_unix` bigint DEFAULT NULL,
  `git_size` bigint DEFAULT NULL,
  `lfs_size` bigint DEFAULT NULL,
  `object_format_name` varchar(6) COLLATE utf8mb4_0900_as_cs DEFAULT NULL,
  `default_wiki_branch` varchar(255) COLLATE utf8mb4_0900_as_cs DEFAULT NULL,
  UNIQUE KEY `UQE_repository_s` (`owner_id`,`lower_name`),
  KEY `IDX_repository_updated_unix` (`updated_unix`),
  KEY `IDX_repository_is_archived` (`is_archived`),
  KEY `IDX_repository_lower_name` (`lower_name`),
  KEY `IDX_repository_is_fork` (`is_fork`),
  KEY `IDX_repository_template_id` (`template_id`),
  KEY `IDX_repository_created_unix` (`created_unix`),
  KEY `IDX_repository_fork_id` (`fork_id`),
  KEY `IDX_repository_is_empty` (`is_empty`),
  KEY `IDX_repository_name` (`name`),
  KEY `IDX_repository_is_template` (`is_template`),
  KEY `IDX_repository_is_mirror` (`is_mirror`),
  KEY `IDX_repository_original_service_type` (`original_service_type`),
  KEY `IDX_repository_owner_id` (`owner_id`),
  KEY `IDX_repository_is_private` (`is_private`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_as_cs ROW_FORMAT=DYNAMIC

[lunny]

Primary Key of this repository table missed?