Adjust the layout of the toolbar on the Issues/Projects page (#33667) #34047
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
wxiaoguang
changed the title
github-actions
bot
added
the
modifies/templates
GiteaBot
added
lgtm/need 1
| <div class="flex-text-block tw-flex-wrap tw-mb-4"> | ||
| <h2 class="tw-mb-0">{{.Project.Title}}</h2> | ||
| <div class="tw-flex-1"></div> | ||
| <div class="ui secondary menu tw-m-0"> |
There was a problem hiding this comment.
This block looks incorrectly intended, it should be on the same level as the empty div above.
There was a problem hiding this comment.
Actually it is correct, the old code doesn't intend correctly.
To avoid unnecessary changes, I kept it as-is.
There was a problem hiding this comment.
To clarify the change: only this line is deleted.
There was a problem hiding this comment.
No, i mean this:
Line 2 should dedent, old code did not have the closing </div> tag that you introduced.
There was a problem hiding this comment.
This line <div class="tw-flex-1"></div> is newly added, it doesn't affect other tags . The newly added line has correct indent
There was a problem hiding this comment.
As I explained above: the only deleted line is <div class="project-toolbar-right"> and its close tag.
You could checkout and check the layout locally.
There was a problem hiding this comment.
I don't care enough about intendation on a soon to be obsolete branch and main branch looks correct.
There was a problem hiding this comment.
Yes, main branch is correct because I did extra formatting.
This PR is only a backport and has to be done manually, I just don't want to introduce too many other changes
GiteaBot
added
lgtm/done
And fix layout for mobile
Backport #33667
Fix #33880