Skip to content

Move organization's visibility change to danger zone. #34814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 21, 2025

image image

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jun 21, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 21, 2025
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jun 21, 2025
@lunny lunny marked this pull request as draft June 22, 2025 17:35
@lunny lunny marked this pull request as ready for review July 1, 2025 19:01
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 3, 2025
@lunny lunny requested a review from wxiaoguang July 5, 2025 00:11
@lunny lunny added this to the 1.25.0 milestone Jul 8, 2025
@@ -2840,6 +2840,14 @@ settings.location = Location
settings.permission = Permissions
settings.repoadminchangeteam = Repository admin can add and remove access for teams
settings.visibility = Visibility
settings.change_visibility = Change Visibility
settings.invalid_visibility = The new visibility is not valid.
settings.change_visibility_notices_1 = This operation <strong>CANNOT</strong> be undone.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there really any destructive operations in some cases that cannot be undone?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, all repository stars will be removed when an organization is converted to private. This behavior follows the logic introduced in #11717. Please note that these stars cannot be restored even if the organization is later changed back to public.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be somehow more detailed because otherwise it looks like visibility change is final and visibility cannot be changed anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

func SettingsChangeVisibilityPost(ctx *context.Context) {
visibility := structs.VisibilityModes[ctx.FormString("visibility")]
if !visibility.IsValid() {
ctx.JSONError(ctx.Tr("org.settings.invalid_visibility"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End users would never see such error message, so please re-use the existing invalid_data tranlsation

}

if ctx.Org.Organization.Visibility == visibility {
ctx.JSONError(ctx.Tr("org.settings.change_visibility_no_change"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be an "error". It can just flash a info or success message.

And there can be a general message that "You did not make any changes"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants