Move organization's visibility change to danger zone. #34814
Conversation
lunny
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/translation
modifies/go
GiteaBot
added
lgtm/need 1
…nto lunny/refactor_org_setting
options/locale/locale_en-US.ini
Outdated
| @@ -2840,6 +2840,14 @@ settings.location = Location | |||
| settings.permission = Permissions | |||
| settings.repoadminchangeteam = Repository admin can add and remove access for teams | |||
| settings.visibility = Visibility | |||
| settings.change_visibility = Change Visibility | |||
| settings.invalid_visibility = The new visibility is not valid. | |||
| settings.change_visibility_notices_1 = This operation <strong>CANNOT</strong> be undone. | |||
There was a problem hiding this comment.
Are there really any destructive operations in some cases that cannot be undone?
There was a problem hiding this comment.
Yes, all repository stars will be removed when an organization is converted to private. This behavior follows the logic introduced in #11717. Please note that these stars cannot be restored even if the organization is later changed back to public.
There was a problem hiding this comment.
Maybe this should be somehow more detailed because otherwise it looks like visibility change is final and visibility cannot be changed anymore
| func SettingsChangeVisibilityPost(ctx *context.Context) { | ||
| visibility := structs.VisibilityModes[ctx.FormString("visibility")] | ||
| if !visibility.IsValid() { | ||
| ctx.JSONError(ctx.Tr("org.settings.invalid_visibility")) |
There was a problem hiding this comment.
End users would never see such error message, so please re-use the existing invalid_data tranlsation
| } | ||
|
|
||
| if ctx.Org.Organization.Visibility == visibility { | ||
| ctx.JSONError(ctx.Tr("org.settings.change_visibility_no_change")) |
There was a problem hiding this comment.
It shouldn't be an "error". It can just flash a info or success message.
And there can be a general message that "You did not make any changes"
Uh oh!
There was an error while loading. Please reload this page.