Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove New prefix from EditorResourcePicker #104604

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Mar 25, 2025

Before After
image image

This allows using incremental search (i.e. press key to jump to item) to find a type, alleviating some problems with too many types in the dialog (especially when exporting Resource). Maybe we could also sort the items alphabetically 🤔

@AdriaandeJongh
Copy link
Contributor

sorting alphabetically is a great idea!

from a UX standpoint, i’m not so sure about removing the word ‘new’ here because the header is very easy to miss (I did for the first minute of looking at this) and now users may think “ah yeah I’ll click Texture because I want to select a texture”. maybe add a small green plus on top of the icon or somewhere, indicating you’re creating something new? or add “(new)” to the end? or keep ‘new’ at the beginning but have the search ignore it?

@KoBeWi
Copy link
Member Author

KoBeWi commented Mar 25, 2025

keep ‘new’ at the beginning but have the search ignore it?

That would require PopupMenu changes, so out of question.
(new) prefix sounds probably fine, but also somewhat redundant.
Would the header be better with an Add icon?

@fire
Copy link
Member

fire commented Mar 25, 2025

Can you do an icon and the name?

@KoBeWi
Copy link
Member Author

KoBeWi commented Mar 25, 2025

Header with an icon:
image
Looks like a button tbh.

Suffix:

image

maybe add a small green plus on top of the icon

Also not supported.

@akien-mga
Copy link
Member

Note that we also have "New ..." language in some other places, like FileSystem dock right click menu:
image

@KoBeWi
Copy link
Member Author

KoBeWi commented Mar 25, 2025

FileSystem options are fixed (always the same) and the "New" is part of the option. They are a bit different from resource menu and IMO fine as is.

tbh I'd just go with the initial option and see if users are indeed confused and whether it's a problem.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. Code looks good to me.

image

@akien-mga akien-mga modified the milestones: 4.x, 4.5 Mar 28, 2025
@akien-mga akien-mga merged commit b4edd92 into godotengine:master Mar 28, 2025
20 checks passed
@KoBeWi KoBeWi deleted the why_new branch March 28, 2025 16:36
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants