Skip to content

Commit cfcd35d

Browse files
author
epriestley
committed
Remove standalone SMS support in favor of a "Mail, SMS, and other media are mostly the same thing" approach
Summary: Ref T920. Over time, mail has become much more complex and I think considering "mail", "sms", "postcards", "whatsapp", etc., to be mostly-the-same is now a more promising avenue than building separate stacks for each one. Throw away all the standalone SMS code, including the Twilio config options. I have a separate diff that adds Twilio as a mail adapter and functions correctly, but it needs some more work to bring upstream. This permanently destroys the `sms` table, which no real reachable code ever wrote to. I'll call this out in the changelog. Test Plan: - Grepped for `SMS` and `Twilio`. - Ran storage upgrade. Reviewers: amckinley Reviewed By: amckinley Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T920 Differential Revision: https://secure.phabricator.com/D19939
1 parent e856e79 commit cfcd35d

16 files changed

+1
-707
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
DROP TABLE {$NAMESPACE}_metamta.sms;

scripts/sms/manage_sms.php

Lines changed: 0 additions & 21 deletions
This file was deleted.

src/__phutil_library_map__.php

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -4239,19 +4239,6 @@
42394239
'PhabricatorResourceSite' => 'aphront/site/PhabricatorResourceSite.php',
42404240
'PhabricatorRobotsController' => 'applications/system/controller/PhabricatorRobotsController.php',
42414241
'PhabricatorS3FileStorageEngine' => 'applications/files/engine/PhabricatorS3FileStorageEngine.php',
4242-
'PhabricatorSMS' => 'infrastructure/sms/storage/PhabricatorSMS.php',
4243-
'PhabricatorSMSConfigOptions' => 'applications/config/option/PhabricatorSMSConfigOptions.php',
4244-
'PhabricatorSMSDAO' => 'infrastructure/sms/storage/PhabricatorSMSDAO.php',
4245-
'PhabricatorSMSDemultiplexWorker' => 'infrastructure/sms/worker/PhabricatorSMSDemultiplexWorker.php',
4246-
'PhabricatorSMSImplementationAdapter' => 'infrastructure/sms/adapter/PhabricatorSMSImplementationAdapter.php',
4247-
'PhabricatorSMSImplementationTestBlackholeAdapter' => 'infrastructure/sms/adapter/PhabricatorSMSImplementationTestBlackholeAdapter.php',
4248-
'PhabricatorSMSImplementationTwilioAdapter' => 'infrastructure/sms/adapter/PhabricatorSMSImplementationTwilioAdapter.php',
4249-
'PhabricatorSMSManagementListOutboundWorkflow' => 'infrastructure/sms/management/PhabricatorSMSManagementListOutboundWorkflow.php',
4250-
'PhabricatorSMSManagementSendTestWorkflow' => 'infrastructure/sms/management/PhabricatorSMSManagementSendTestWorkflow.php',
4251-
'PhabricatorSMSManagementShowOutboundWorkflow' => 'infrastructure/sms/management/PhabricatorSMSManagementShowOutboundWorkflow.php',
4252-
'PhabricatorSMSManagementWorkflow' => 'infrastructure/sms/management/PhabricatorSMSManagementWorkflow.php',
4253-
'PhabricatorSMSSendWorker' => 'infrastructure/sms/worker/PhabricatorSMSSendWorker.php',
4254-
'PhabricatorSMSWorker' => 'infrastructure/sms/worker/PhabricatorSMSWorker.php',
42554242
'PhabricatorSQLPatchList' => 'infrastructure/storage/patch/PhabricatorSQLPatchList.php',
42564243
'PhabricatorSSHKeyGenerator' => 'infrastructure/util/PhabricatorSSHKeyGenerator.php',
42574244
'PhabricatorSSHKeysSettingsPanel' => 'applications/settings/panel/PhabricatorSSHKeysSettingsPanel.php',
@@ -10269,19 +10256,6 @@
1026910256
'PhabricatorResourceSite' => 'PhabricatorSite',
1027010257
'PhabricatorRobotsController' => 'PhabricatorController',
1027110258
'PhabricatorS3FileStorageEngine' => 'PhabricatorFileStorageEngine',
10272-
'PhabricatorSMS' => 'PhabricatorSMSDAO',
10273-
'PhabricatorSMSConfigOptions' => 'PhabricatorApplicationConfigOptions',
10274-
'PhabricatorSMSDAO' => 'PhabricatorLiskDAO',
10275-
'PhabricatorSMSDemultiplexWorker' => 'PhabricatorSMSWorker',
10276-
'PhabricatorSMSImplementationAdapter' => 'Phobject',
10277-
'PhabricatorSMSImplementationTestBlackholeAdapter' => 'PhabricatorSMSImplementationAdapter',
10278-
'PhabricatorSMSImplementationTwilioAdapter' => 'PhabricatorSMSImplementationAdapter',
10279-
'PhabricatorSMSManagementListOutboundWorkflow' => 'PhabricatorSMSManagementWorkflow',
10280-
'PhabricatorSMSManagementSendTestWorkflow' => 'PhabricatorSMSManagementWorkflow',
10281-
'PhabricatorSMSManagementShowOutboundWorkflow' => 'PhabricatorSMSManagementWorkflow',
10282-
'PhabricatorSMSManagementWorkflow' => 'PhabricatorManagementWorkflow',
10283-
'PhabricatorSMSSendWorker' => 'PhabricatorSMSWorker',
10284-
'PhabricatorSMSWorker' => 'PhabricatorWorker',
1028510259
'PhabricatorSQLPatchList' => 'Phobject',
1028610260
'PhabricatorSSHKeyGenerator' => 'Phobject',
1028710261
'PhabricatorSSHKeysSettingsPanel' => 'PhabricatorSettingsPanel',

src/applications/config/option/PhabricatorSMSConfigOptions.php

Lines changed: 0 additions & 60 deletions
This file was deleted.

src/infrastructure/sms/adapter/PhabricatorSMSImplementationAdapter.php

Lines changed: 0 additions & 88 deletions
This file was deleted.

src/infrastructure/sms/adapter/PhabricatorSMSImplementationTestBlackholeAdapter.php

Lines changed: 0 additions & 31 deletions
This file was deleted.

src/infrastructure/sms/adapter/PhabricatorSMSImplementationTwilioAdapter.php

Lines changed: 0 additions & 99 deletions
This file was deleted.

0 commit comments

Comments
 (0)