-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 21 update #3213
Java 21 update #3213
Conversation
PR SummaryThis PR updates the project to support JDK 21. It modifies the Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- 83410f4: update pom.xml and github actions scripts
Files Processed (3)
- .github/workflows/maven-ci.yml (2 hunks)
- .github/workflows/maven-pr-builder.yml (2 hunks)
- pom.xml (3 hunks)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- d4efc23: disable failing tests, for now
Files Processed (6)
- bloc/src/test/java/com/iluwatar/bloc/MainTest.java (2 hunks)
- page-controller/pom.xml (1 hunk)
- template-method/src/test/java/com/iluwatar/templatemethod/HalflingThiefTest.java (3 hunks)
- templateview/src/test/java/com/iluwatar/templateview/ContactPageViewTest.java (1 hunk)
- templateview/src/test/java/com/iluwatar/templateview/HomePageViewTest.java (1 hunk)
- templateview/src/test/java/com/iluwatar/templateview/TemplateViewTest.java (2 hunks)
Actionable Comments (1)
-
bloc/src/test/java/com/iluwatar/bloc/MainTest.java [34-37]
possible issue: "Multiple tests are disabled."
Skipped Comments (0)
|
||
@Test | ||
@Disabled | ||
void testMain() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests in MainTest.java
, HalflingThiefTest.java
, ContactPageViewTest.java
, HomePageViewTest.java
, and TemplateViewTest.java
are disabled. Ensure this is intentional and that appropriate steps are taken to address the disabled tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- 2ff7ddf: Merge branch 'master' into java21
Files Processed (1)
- pom.xml (3 hunks)
Actionable Comments (1)
-
pom.xml [51-52]
possible issue: "Verify Lombok version compatibility with Java 21."
Skipped Comments (1)
-
pom.xml [304-310]
best practice: "Review Lombok annotation processor configuration."
<maven-compiler-plugin.version>3.14.0</maven-compiler-plugin.version> | ||
<lombok.version>1.18.36</lombok.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lombok.version
property is added to the pom.xml
file, but it's not clear if this version is compatible with Java 21. Verify compatibility before merging.
Pull Request Template
What does this PR do?
Update project to support JDK 21