Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 21 update #3213

Merged
merged 3 commits into from
Mar 25, 2025
Merged

Java 21 update #3213

merged 3 commits into from
Mar 25, 2025

Conversation

iluwatar
Copy link
Owner

Pull Request Template

What does this PR do?

Update project to support JDK 21

Copy link

github-actions bot commented Mar 20, 2025

PR Summary

This PR updates the project to support JDK 21. It modifies the pom.xml files to use Java 21 and updates the Github Actions workflows to use JDK 21. Additionally, several test files have been disabled.

Changes

File Summary
.github/workflows/maven-ci.yml Updated the Java CI workflow to use JDK 21 and ubuntu-22.04. The workflow now builds and runs Sonar analysis on JDK 21.
.github/workflows/maven-pr-builder.yml Updated the Java PR Builder workflow to use JDK 21 and ubuntu-22.04. The workflow now builds on JDK 21.
bloc/src/test/java/com/iluwatar/bloc/MainTest.java The testMain method in MainTest.java is now disabled using @Disabled annotation.
page-controller/pom.xml Removed the spring-boot-maven-plugin from the pom.xml file.
pom.xml Updated the project to use Java 21 and updated the lombok version to 1.18.36. Added annotationProcessorPaths for lombok.
template-method/src/test/java/com/iluwatar/templatemethod/HalflingThiefTest.java The testSteal and testChangeMethod methods in HalflingThiefTest.java are now disabled using @Disabled annotation.
templateview/src/test/java/com/iluwatar/templateview/ContactPageViewTest.java The testRenderDynamicContent method in ContactPageViewTest.java is now disabled using @Disabled annotation.
templateview/src/test/java/com/iluwatar/templateview/HomePageViewTest.java The testRenderDynamicContent method in HomePageViewTest.java is now disabled using @Disabled annotation.
templateview/src/test/java/com/iluwatar/templateview/TemplateViewTest.java The testRenderHomePage and testRenderContactPage methods in TemplateViewTest.java are now disabled using @Disabled annotation.

autogenerated by presubmit.ai

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
  • 83410f4: update pom.xml and github actions scripts
Files Processed (3)
  • .github/workflows/maven-ci.yml (2 hunks)
  • .github/workflows/maven-pr-builder.yml (2 hunks)
  • pom.xml (3 hunks)
Actionable Comments (0)
Skipped Comments (0)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Pull request needs attention.

Review Summary

Commits Considered (1)
  • d4efc23: disable failing tests, for now
Files Processed (6)
  • bloc/src/test/java/com/iluwatar/bloc/MainTest.java (2 hunks)
  • page-controller/pom.xml (1 hunk)
  • template-method/src/test/java/com/iluwatar/templatemethod/HalflingThiefTest.java (3 hunks)
  • templateview/src/test/java/com/iluwatar/templateview/ContactPageViewTest.java (1 hunk)
  • templateview/src/test/java/com/iluwatar/templateview/HomePageViewTest.java (1 hunk)
  • templateview/src/test/java/com/iluwatar/templateview/TemplateViewTest.java (2 hunks)
Actionable Comments (1)
  • bloc/src/test/java/com/iluwatar/bloc/MainTest.java [34-37]

    possible issue: "Multiple tests are disabled."

Skipped Comments (0)

Comment on lines 34 to 37

@Test
@Disabled
void testMain() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests in MainTest.java, HalflingThiefTest.java, ContactPageViewTest.java, HomePageViewTest.java, and TemplateViewTest.java are disabled. Ensure this is intentional and that appropriate steps are taken to address the disabled tests.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Pull request needs attention.

Review Summary

Commits Considered (1)
  • 2ff7ddf: Merge branch 'master' into java21
Files Processed (1)
  • pom.xml (3 hunks)
Actionable Comments (1)
  • pom.xml [51-52]

    possible issue: "Verify Lombok version compatibility with Java 21."

Skipped Comments (1)
  • pom.xml [304-310]

    best practice: "Review Lombok annotation processor configuration."

Comment on lines +51 to +52
<maven-compiler-plugin.version>3.14.0</maven-compiler-plugin.version>
<lombok.version>1.18.36</lombok.version>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lombok.version property is added to the pom.xml file, but it's not clear if this version is compatible with Java 21. Verify compatibility before merging.

@iluwatar iluwatar merged commit a6c7d3d into master Mar 25, 2025
1 of 2 checks passed
@iluwatar iluwatar deleted the java21 branch March 25, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant