fix(web): svelte-i18n formatting does not trigger inside single quotes #16781
+37
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i18n/en.json
Outdated
| @@ -187,7 +187,7 @@ | |||
| "oauth_issuer_url": "Issuer URL", | |||
| "oauth_mobile_redirect_uri": "Mobile redirect URI", | |||
| "oauth_mobile_redirect_uri_override": "Mobile redirect URI override", | |||
| "oauth_mobile_redirect_uri_override_description": "Enable when OAuth provider does not allow a mobile URI, like '{callback}'", | |||
| "oauth_mobile_redirect_uri_override_description": "Enable when OAuth provider does not allow a mobile URI, like \"{callback}\"", | |||
There was a problem hiding this comment.
If you want to preserve the single quotes in the output message, you can use two of them to escape them.
Suggested change
| "oauth_mobile_redirect_uri_override_description": "Enable when OAuth provider does not allow a mobile URI, like \"{callback}\"", | |
| "oauth_mobile_redirect_uri_override_description": "Enable when OAuth provider does not allow a mobile URI, like ''{callback}''", |
https://formatjs.github.io/docs/core-concepts/icu-syntax#quoting--escaping
There was a problem hiding this comment.
@Snowknight26 Applied in 361e591 🙏
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
eliottness
force-pushed
the
fix-templating
branch
from
e3edcf2 to
361e591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a formatting issue in the setting description for the mobile redirect uri override in the OAuth Administration panel.
Fixes #16779
How Has This Been Tested?
Screenshots (if appropriate)
Previously:
Now:
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)