Skip to content

Commit e1ad312

Browse files
author
epriestley
committedMay 23, 2016
Fix one more "Reviewers" wire format issue
Summary: Fixes T11010. This also needs to be inflated until we fix the whole client/server responsibility issue here. Test Plan: - Created a revision while observing error log, no error. - Disabled "allow self accept", tried to make myself a reviewer, got rejected with an error message. Reviewers: chad Reviewed By: chad Maniphest Tasks: T11010 Differential Revision: https://secure.phabricator.com/D15966
1 parent 627b95b commit e1ad312

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed
 

‎src/applications/differential/customfield/DifferentialReviewersField.php

+1
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ public function validateCommitMessageValue($value) {
242242
$config_self_accept_key = 'differential.allow-self-accept';
243243
$allow_self_accept = PhabricatorEnv::getEnvConfig($config_self_accept_key);
244244

245+
$value = $this->inflateReviewers($value);
245246
foreach ($value as $spec) {
246247
$phid = $spec['phid'];
247248

0 commit comments

Comments
 (0)
Failed to load comments.