Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: phacility/phabricator
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: jakobw/phabricator
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 16, 2014

  1. Fix Conduit project.create breaking with empty members list. 

    Project.create currently breaks if you omit the optional members
argument. A simple null check fixes this.
    @jakobw
    jakobw committed Oct 16, 2014
    Copy the full SHA
    affac01 View commit details
Showing with 9 additions and 7 deletions.
  1. +9 −7 src/applications/project/conduit/ProjectCreateConduitAPIMethod.php
16 changes: 9 additions & 7 deletions src/applications/project/conduit/ProjectCreateConduitAPIMethod.php
View file
Original file line number Diff line number Diff line change
@@ -41,13 +41,15 @@ protected function execute(ConduitAPIRequest $request) {
->setTransactionType($type_name)
->setNewValue($request->getValue('name'));

$xactions[] = id(new PhabricatorProjectTransaction())
->setTransactionType(PhabricatorTransactions::TYPE_EDGE)
->setMetadataValue('edge:type', PhabricatorEdgeConfig::TYPE_PROJ_MEMBER)
->setNewValue(
array(
'+' => array_fuse($members),
));
if ($members !== null) {
$xactions[] = id(new PhabricatorProjectTransaction())
->setTransactionType(PhabricatorTransactions::TYPE_EDGE)
->setMetadataValue('edge:type', PhabricatorEdgeConfig::TYPE_PROJ_MEMBER)
->setNewValue(
array(
'+' => array_fuse($members),
));
}

$editor = id(new PhabricatorProjectTransactionEditor())
->setActor($user)