Fix method call on possible null

epriestley · epriestley · commit 3f920d890474 · 2016-02-10T12:44:52.000-08:00
Summary: Fixes T10317. If we failed to load `$device`, it will be null, so we won't be able to call `getName()` on it. Test Plan: `SSH_CLIENT='127.0.0.1' ./bin/ssh-exec --phabricator-ssh-device xyz` no longer fatals Reviewers: chad Reviewed By: chad Maniphest Tasks: T10317 Differential Revision: https://secure.phabricator.com/D15235
diff --git a/scripts/ssh/ssh-exec.php b/scripts/ssh/ssh-exec.php
@@ -129,7 +129,7 @@
       throw new Exception(
         pht(
           'Invalid device name ("%s"). There is no device with this name.',
-          $device->getName()));
+          $device_name));
     }
 
     // We're authenticated as a device, but we're going to read the user out of

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@`
`129`	`129`	`throw new Exception(`
`130`	`130`	`pht(`
`131`	`131`	`'Invalid device name ("%s"). There is no device with this name.',`
`132`		`- $device->getName()));`
	`132`	`+ $device_name));`
`133`	`133`	`}`
`134`	`134`
`135`	`135`	`// We're authenticated as a device, but we're going to read the user out of`