Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract

Summary: Fixes T9625. As explained in a `TODO` comment, seems reasonable enough.

Test Plan: Unit tests.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, hach-que

Maniphest Tasks: T9625

Differential Revision: https://secure.phabricator.com/D14068

Author: Joshua Spence

src/applications/almanac/phid/AlmanacBindingPHIDType.php

@@ -12,6 +12,10 @@ public function newObject() {
     return new AlmanacBinding();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorAlmanacApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/almanac/phid/AlmanacDevicePHIDType.php

@@ -12,6 +12,10 @@ public function newObject() {
     return new AlmanacDevice();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorAlmanacApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {