Skip to content

Commit 7f6508a

Browse files
committedJun 18, 2015
Add missing execution on archived task query
Summary: Fixes T8599. I'm not sure how to reproduce the original issue, but I'm fairly confident that the issue is that the issue is that `execute()` is not called on the query object. Test Plan: Created a Harbormaster build plan with a single "Lease Host" step. Ran `./bin/harbormaster build --plan 1 D1` from the command line and hit the exception as described in T8599. Applied patch and hit a different exception (which I think is just because I don't know how to use #drydock and #harbormaster). Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: hach-que, epriestley, Korvin Maniphest Tasks: T8599 Differential Revision: https://secure.phabricator.com/D13335
1 parent dad2917 commit 7f6508a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed
 

‎src/infrastructure/daemon/workers/PhabricatorWorker.php

+2-1
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,8 @@ final public static function waitForTasks(array $task_ids) {
199199
}
200200

201201
$tasks = id(new PhabricatorWorkerArchiveTaskQuery())
202-
->withIDs($task_ids);
202+
->withIDs($task_ids)
203+
->execute();
203204

204205
foreach ($tasks as $task) {
205206
if ($task->getResult() != PhabricatorWorkerArchiveTask::RESULT_SUCCESS) {

0 commit comments

Comments
 (0)
Failed to load comments.