Skip to content

Commit cbd3c0b

Browse files
author
epriestley
committedMay 10, 2013
Add action icons to object list views
Summary: We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well. Instead, provide first-class actions: {F42978} They produce targets which my meaty ham-fists can plausibly hit on mobile, too: {F42979} (We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?) Test Plan: Added UIExamples. Checked desktop/mobile. Reviewers: chad, btrahan, edward Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5890
1 parent 2d3e759 commit cbd3c0b

38 files changed

+1853
-1710
lines changed
 

‎resources/sprite/manifest/actions.json

+52-52
Original file line numberDiff line numberDiff line change
@@ -3,198 +3,198 @@
33
"sprites" : {
44
"actions-close-dark" : {
55
"name" : "actions-close-dark",
6-
"rule" : ".actions-close-dark, .device-desktop .actions-close-grey.phui-icon-item-link:hover",
7-
"hash" : "7604975dc64a124369a3e54a155ba55f"
6+
"rule" : ".actions-close-dark, .device-desktop .actions-close-grey.phui-icon-view:hover",
7+
"hash" : "d371ba7921b4ff14f2f829b8108abe87"
88
},
99
"actions-close-grey" : {
1010
"name" : "actions-close-grey",
1111
"rule" : ".actions-close-grey",
12-
"hash" : "22d7706066666cf0ba91f5ae4ef96f1f"
12+
"hash" : "bec8b545648d31317774e7c2580e3d14"
1313
},
1414
"actions-close-white" : {
1515
"name" : "actions-close-white",
1616
"rule" : ".actions-close-white",
17-
"hash" : "8d6ad8fc33b0e9471dc2c6d4de6e7341"
17+
"hash" : "52067fda0c9664f97dea0e5d9cd792f0"
1818
},
1919
"actions-down-dark" : {
2020
"name" : "actions-down-dark",
21-
"rule" : ".actions-down-dark, .device-desktop .actions-down-grey.phui-icon-item-link:hover",
22-
"hash" : "4bb5a5a48eb5886c7d6a46d6618823a9"
21+
"rule" : ".actions-down-dark, .device-desktop .actions-down-grey.phui-icon-view:hover",
22+
"hash" : "6ee657d4245d2ec7d5b5e61ff2401da1"
2323
},
2424
"actions-down-grey" : {
2525
"name" : "actions-down-grey",
2626
"rule" : ".actions-down-grey",
27-
"hash" : "5334fe6173a3fe85c4683fe079e03104"
27+
"hash" : "146c17409712ba10ce0c567c86f31bf1"
2828
},
2929
"actions-down-white" : {
3030
"name" : "actions-down-white",
3131
"rule" : ".actions-down-white",
32-
"hash" : "65c4eb9c6b1a897ca7454aea0459db83"
32+
"hash" : "dd01d18cca43f2ce2cbaa6f73b8257e1"
3333
},
3434
"actions-flag-dark" : {
3535
"name" : "actions-flag-dark",
36-
"rule" : ".actions-flag-dark, .device-desktop .actions-flag-grey.phui-icon-item-link:hover",
37-
"hash" : "4ae54fc28dd2d6cfa6e57dde7bd640cf"
36+
"rule" : ".actions-flag-dark, .device-desktop .actions-flag-grey.phui-icon-view:hover",
37+
"hash" : "1a8320f19cd7bb44d29ee07b4ff5cfc2"
3838
},
3939
"actions-flag-grey" : {
4040
"name" : "actions-flag-grey",
4141
"rule" : ".actions-flag-grey",
42-
"hash" : "50e739ca2d6a5527ce2bb8aafd4eb93f"
42+
"hash" : "e8a76919b35c51a8436b8cd4c55bc269"
4343
},
4444
"actions-flag-white" : {
4545
"name" : "actions-flag-white",
4646
"rule" : ".actions-flag-white",
47-
"hash" : "d29ba4e3f88d5b2f3b0ea14754f7b89a"
47+
"hash" : "b344aaa6d80104e3d79bf9711fa42c60"
4848
},
4949
"actions-heart-dark" : {
5050
"name" : "actions-heart-dark",
51-
"rule" : ".actions-heart-dark, .device-desktop .actions-heart-grey.phui-icon-item-link:hover",
52-
"hash" : "90b437a281724a4961e33272eafd616b"
51+
"rule" : ".actions-heart-dark, .device-desktop .actions-heart-grey.phui-icon-view:hover",
52+
"hash" : "6f4aeb4a6ab5cca45f4cecbac18e2c13"
5353
},
5454
"actions-heart-grey" : {
5555
"name" : "actions-heart-grey",
5656
"rule" : ".actions-heart-grey",
57-
"hash" : "cd521a7267b321516223462860373f09"
57+
"hash" : "b4ef7c03ccb5a4a0ef55a1a1369357c9"
5858
},
5959
"actions-heart-white" : {
6060
"name" : "actions-heart-white",
6161
"rule" : ".actions-heart-white",
62-
"hash" : "505ebd7324f9c39fa2366a85996d1194"
62+
"hash" : "f0394eb2b30463fafbb77c66332e6eb6"
6363
},
6464
"actions-move-dark" : {
6565
"name" : "actions-move-dark",
66-
"rule" : ".actions-move-dark, .device-desktop .actions-move-grey.phui-icon-item-link:hover",
67-
"hash" : "38f5b9168bf04d1a904b09805e589cd7"
66+
"rule" : ".actions-move-dark, .device-desktop .actions-move-grey.phui-icon-view:hover",
67+
"hash" : "b0bb220c8909368bfd8b161c30ebf9e4"
6868
},
6969
"actions-move-grey" : {
7070
"name" : "actions-move-grey",
7171
"rule" : ".actions-move-grey",
72-
"hash" : "35dcc45f04a81cbf9e5ecdf0fcd5bebc"
72+
"hash" : "80b5c487ee61d5388f172c234d5d6547"
7373
},
7474
"actions-move-white" : {
7575
"name" : "actions-move-white",
7676
"rule" : ".actions-move-white",
77-
"hash" : "2b1b790a494a079d288d5a3a47c6bd62"
77+
"hash" : "c0babe1697ab7753c40efaede8aaf680"
7878
},
7979
"actions-new-dark" : {
8080
"name" : "actions-new-dark",
81-
"rule" : ".actions-new-dark, .device-desktop .actions-new-grey.phui-icon-item-link:hover",
82-
"hash" : "52c45b76d0dbd51e6eb65f0597d5098a"
81+
"rule" : ".actions-new-dark, .device-desktop .actions-new-grey.phui-icon-view:hover",
82+
"hash" : "40e6738b606010c4a4b81decc66e91c7"
8383
},
8484
"actions-new-grey" : {
8585
"name" : "actions-new-grey",
8686
"rule" : ".actions-new-grey",
87-
"hash" : "c51315bd83a20806625ca3a887f86215"
87+
"hash" : "60f78d578fef99834f1a429887524ca2"
8888
},
8989
"actions-new-white" : {
9090
"name" : "actions-new-white",
9191
"rule" : ".actions-new-white",
92-
"hash" : "5a344c62e037d672516dae0e3a8dd589"
92+
"hash" : "b2345dd8353c0ddd2d99775542d62360"
9393
},
9494
"actions-search-dark" : {
9595
"name" : "actions-search-dark",
96-
"rule" : ".actions-search-dark, .device-desktop .actions-search-grey.phui-icon-item-link:hover",
97-
"hash" : "6ff124bc9423bf98be5a53e22508cd26"
96+
"rule" : ".actions-search-dark, .device-desktop .actions-search-grey.phui-icon-view:hover",
97+
"hash" : "ddc5d23c829e17d38ba2ea2cea9fd6c4"
9898
},
9999
"actions-search-grey" : {
100100
"name" : "actions-search-grey",
101101
"rule" : ".actions-search-grey",
102-
"hash" : "57b5c47c0676da7f97d3b2f7eefbbea4"
102+
"hash" : "c6c8214375b3442a890b48a75ee95c0d"
103103
},
104104
"actions-search-white" : {
105105
"name" : "actions-search-white",
106106
"rule" : ".actions-search-white",
107-
"hash" : "17f1bf9820b0c44f4641e0256840b138"
107+
"hash" : "25b9bfb1808547f8b141ea35d7764353"
108108
},
109109
"actions-settings-dark" : {
110110
"name" : "actions-settings-dark",
111-
"rule" : ".actions-settings-dark, .device-desktop .actions-settings-grey.phui-icon-item-link:hover",
112-
"hash" : "5ecb08643250a052e5d090ef4660faf5"
111+
"rule" : ".actions-settings-dark, .device-desktop .actions-settings-grey.phui-icon-view:hover",
112+
"hash" : "7b5abbebcdfec9137c66e36cfad13071"
113113
},
114114
"actions-settings-grey" : {
115115
"name" : "actions-settings-grey",
116116
"rule" : ".actions-settings-grey",
117-
"hash" : "5aeb35f1019c51a2f9140dc8765c9dca"
117+
"hash" : "970decba8ae9bb183d6f090d196c7fc5"
118118
},
119119
"actions-settings-white" : {
120120
"name" : "actions-settings-white",
121121
"rule" : ".actions-settings-white",
122-
"hash" : "8cdd154946f1a8d8d307b72eddd5d755"
122+
"hash" : "368c765c374b059ab25e41d1f7204aa8"
123123
},
124124
"actions-star-dark" : {
125125
"name" : "actions-star-dark",
126-
"rule" : ".actions-star-dark, .device-desktop .actions-star-grey.phui-icon-item-link:hover",
127-
"hash" : "45567d03f8e34811eca0621e93b5e050"
126+
"rule" : ".actions-star-dark, .device-desktop .actions-star-grey.phui-icon-view:hover",
127+
"hash" : "17270fb5f28101f65040c854c04a8857"
128128
},
129129
"actions-star-grey" : {
130130
"name" : "actions-star-grey",
131131
"rule" : ".actions-star-grey",
132-
"hash" : "1c7909e987b64b26b728506695457770"
132+
"hash" : "dcbabdf40a79100d51d372ae9e8716ff"
133133
},
134134
"actions-star-white" : {
135135
"name" : "actions-star-white",
136136
"rule" : ".actions-star-white",
137-
"hash" : "e7c949542a54a347879ceb96f42a3c02"
137+
"hash" : "845ce22ed1e7eeed4f45047fa9325ab3"
138138
},
139139
"actions-tag-dark" : {
140140
"name" : "actions-tag-dark",
141-
"rule" : ".actions-tag-dark, .device-desktop .actions-tag-grey.phui-icon-item-link:hover",
142-
"hash" : "24d97fa7524d0bf1bac17d9e07a63f48"
141+
"rule" : ".actions-tag-dark, .device-desktop .actions-tag-grey.phui-icon-view:hover",
142+
"hash" : "b5dbc809ac52d464e5bf29c84c2d9a29"
143143
},
144144
"actions-tag-grey" : {
145145
"name" : "actions-tag-grey",
146146
"rule" : ".actions-tag-grey",
147-
"hash" : "f04a5b38209c0f8e9ad2a3a964d5d505"
147+
"hash" : "0558ef19806b5f89d2af585178c4afc1"
148148
},
149149
"actions-tag-white" : {
150150
"name" : "actions-tag-white",
151151
"rule" : ".actions-tag-white",
152-
"hash" : "fdfc5d20f6a0d90b6d329159823d2cb0"
152+
"hash" : "ecd4ae0949552a9bae0fe277408a77d8"
153153
},
154154
"actions-token-dark" : {
155155
"name" : "actions-token-dark",
156-
"rule" : ".actions-token-dark, .device-desktop .actions-token-grey.phui-icon-item-link:hover",
157-
"hash" : "e7f973c27cc60cbd730e60779e07e7f2"
156+
"rule" : ".actions-token-dark, .device-desktop .actions-token-grey.phui-icon-view:hover",
157+
"hash" : "454c1afb874dec4f1df5695e7eff7326"
158158
},
159159
"actions-token-grey" : {
160160
"name" : "actions-token-grey",
161161
"rule" : ".actions-token-grey",
162-
"hash" : "aede0f8cdf5b4d568ab57fc44fbeeaf6"
162+
"hash" : "04d9fc2dd373804d00b60a576d6cc94f"
163163
},
164164
"actions-token-white" : {
165165
"name" : "actions-token-white",
166166
"rule" : ".actions-token-white",
167-
"hash" : "78a34242d2fecf78a4d6eba6dafff452"
167+
"hash" : "0354f489a9f1bafd9d88181c7e8959ff"
168168
},
169169
"actions-up-dark" : {
170170
"name" : "actions-up-dark",
171-
"rule" : ".actions-up-dark, .device-desktop .actions-up-grey.phui-icon-item-link:hover",
172-
"hash" : "c3899cd39cbfb47d442d157e78deaff6"
171+
"rule" : ".actions-up-dark, .device-desktop .actions-up-grey.phui-icon-view:hover",
172+
"hash" : "f922e6b5ddde61c63cb25fc69f29ac59"
173173
},
174174
"actions-up-grey" : {
175175
"name" : "actions-up-grey",
176176
"rule" : ".actions-up-grey",
177-
"hash" : "534a185d53a991616a0bfff2c619625c"
177+
"hash" : "188470ed37fbee2bedf8cf099601b2cc"
178178
},
179179
"actions-up-white" : {
180180
"name" : "actions-up-white",
181181
"rule" : ".actions-up-white",
182-
"hash" : "42e27f001c90d17c806b7dc6f5da1535"
182+
"hash" : "a34868ad7c6af02b8bba5c2c67f261b0"
183183
},
184184
"actions-wrench-dark" : {
185185
"name" : "actions-wrench-dark",
186-
"rule" : ".actions-wrench-dark, .device-desktop .actions-wrench-grey.phui-icon-item-link:hover",
187-
"hash" : "3a5cfa463c3c89194d3bbce3952a6e80"
186+
"rule" : ".actions-wrench-dark, .device-desktop .actions-wrench-grey.phui-icon-view:hover",
187+
"hash" : "376d45f6796291816d2a4679021e2181"
188188
},
189189
"actions-wrench-grey" : {
190190
"name" : "actions-wrench-grey",
191191
"rule" : ".actions-wrench-grey",
192-
"hash" : "40d8a77d6272589c69f65e9b5e5587e1"
192+
"hash" : "ac1cf1f6a12367eb3a5a3b36e400b26d"
193193
},
194194
"actions-wrench-white" : {
195195
"name" : "actions-wrench-white",
196196
"rule" : ".actions-wrench-white",
197-
"hash" : "20ee83ae6a5d0dc6918727b6ccacec67"
197+
"hash" : "5ed6e55f0b52949fe02bde899ce86b34"
198198
}
199199
},
200200
"scales" : [

0 commit comments

Comments
 (0)
Failed to load comments.