Skip to content

Commit a7b3ba5

Browse files
author
epriestley
committedJun 29, 2020
When long monospaced character sequences appear in Remarkup tables, break rather than scrolling
Summary: Ref PHI1798. If you put an SSH public key in a table cell with monospaced formatting and then print the table, the cell scrolls and not all of the content appears in your physical printed document. Generally, the current scrolling behavior for monospaced text seems never-desirable: I can't imagine any cases where we want the table cell to scroll. (There's more of an argument for complex cases where a table cell has, say, an embedded paste.) Add `line-break: anywhere` to break monospaced text inside these cells. Test Plan: In Safari, Firefox, and Chrome, viewed a ##|`MMMMM....`|## table. Saw scrolling before and wrapping/breaking after. Differential Revision: https://secure.phabricator.com/D21370
1 parent 22de618 commit a7b3ba5

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed
 

‎resources/celerity/map.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
'names' => array(
1010
'conpherence.pkg.css' => '0e3cf785',
1111
'conpherence.pkg.js' => '020aebcf',
12-
'core.pkg.css' => 'ba768cdb',
12+
'core.pkg.css' => 'da792a0f',
1313
'core.pkg.js' => '845355f4',
1414
'dark-console.pkg.js' => '187792c2',
1515
'differential.pkg.css' => '5c459f92',
@@ -114,7 +114,7 @@
114114
'rsrc/css/application/tokens/tokens.css' => 'ce5a50bd',
115115
'rsrc/css/application/uiexample/example.css' => 'b4795059',
116116
'rsrc/css/core/core.css' => '1b29ed61',
117-
'rsrc/css/core/remarkup.css' => 'c286eaef',
117+
'rsrc/css/core/remarkup.css' => '7d3ebc86',
118118
'rsrc/css/core/syntax.css' => '548567f6',
119119
'rsrc/css/core/z-index.css' => 'ac3bfcd4',
120120
'rsrc/css/diviner/diviner-shared.css' => '4bd263b0',
@@ -798,7 +798,7 @@
798798
'phabricator-object-selector-css' => 'ee77366f',
799799
'phabricator-phtize' => '2f1db1ed',
800800
'phabricator-prefab' => '5793d835',
801-
'phabricator-remarkup-css' => 'c286eaef',
801+
'phabricator-remarkup-css' => '7d3ebc86',
802802
'phabricator-search-results-css' => '9ea70ace',
803803
'phabricator-shaped-request' => '995f5102',
804804
'phabricator-slowvote-css' => '1694baed',

‎webroot/rsrc/css/core/remarkup.css

+1
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@
8686
padding: 1px 4px;
8787
border-radius: 3px;
8888
white-space: pre-wrap;
89+
line-break: anywhere;
8990
}
9091

9192
/* NOTE: You can currently produce this with [[link | `name`]]. Restore the

0 commit comments

Comments
 (0)
Failed to load comments.