chore: use %e token anywhere we are logging errors with @libp2p/logger #3175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
requested changes
Jun 4, 2025
achingbrain
requested changes
Jun 4, 2025
SgtPooki
requested changes
Jun 4, 2025
packages/transport-webrtc/src/private-to-private/initiate-connection.ts
Outdated
Show resolved
Hide resolved
packages/transport-webrtc/src/private-to-private/signaling-stream-handler.ts
Outdated
Show resolved
Hide resolved
achingbrain
requested changes
Jun 5, 2025
| log.error(err) | ||
| }) | ||
| .catch(err => { | ||
| log.error('incoming stream handler error - %e', err) |
There was a problem hiding this comment.
Good to add more context to this message but there is an unrelated formatting change, please keep the additional context but revert the reformatting.
packages/transport-webrtc/src/private-to-private/initiate-connection.ts
Outdated
Show resolved
Hide resolved
packages/transport-webrtc/src/private-to-private/signaling-stream-handler.ts
Outdated
Show resolved
Hide resolved
packages/transport-webrtc/src/private-to-private/signaling-stream-handler.ts
Outdated
Show resolved
Hide resolved
|
@SuchitraSwain thanks for the PR - for next steps. Please address the review comments left here |
achingbrain
requested changes
Jun 17, 2025
packages/transport-webrtc/src/private-to-private/signaling-stream-handler.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Description
Notes & open questions
Change checklist