Skip to content

Commit d0f96be

Browse files
committed
[FPEnv] A missing crucial step was undocumented.
llvm-svn: 364328
1 parent a90fc66 commit d0f96be

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

llvm/docs/AddingConstrainedIntrinsics.rst

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,14 @@ be properly handled.::
8181

8282
lib/CodeGen/SelectionDAG/SelectionDAG.cpp
8383

84+
However, the mutation may not happen if the new node has not been registered
85+
in TargetLoweringBase::initActions(). If the corresponding non-STRICT node
86+
is Legal but a target does not know about STRICT nodes then the STRICT
87+
node will default to Legal and mutation will be bypassed with a "Cannot
88+
select" error. Register the new STRICT node as Expand to avoid this bug.::
89+
90+
lib/CodeGen/TargetLoweringBase.cpp
91+
8492
To make debug logs readable it is helpful to update the SelectionDAG's
8593
debug logger:::
8694

0 commit comments

Comments
 (0)