Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hexagon] Default target for assembler doesn't match compiler #127558

Closed
androm3da opened this issue Feb 18, 2025 · 2 comments · Fixed by #132304
Closed

[hexagon] Default target for assembler doesn't match compiler #127558

androm3da opened this issue Feb 18, 2025 · 2 comments · Fixed by #132304
Assignees
Labels
backend:Hexagon enhancement Improving things as opposed to bug fixing, e.g. new or missing feature lld:ELF

Comments

@androm3da
Copy link
Member

androm3da commented Feb 18, 2025

#125239 changed the compiler driver to target hexagonv68 by default. For the sake of consistency, the assembler and linker (lld) should make a corresponding change.

Also, when making this change please also describe the effects in the 21.0 LLVM release notes.

@androm3da androm3da changed the title [hexagon] Default target for compiler doesn't match assembler [hexagon] Default target for assembler doesn't match compiler Feb 18, 2025
@androm3da androm3da added enhancement Improving things as opposed to bug fixing, e.g. new or missing feature backend:Hexagon and removed new issue labels Feb 18, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 18, 2025

@llvm/issue-subscribers-backend-hexagon

Author: Brian Cain (androm3da)

#125239 changed the compiler driver to target `hexagonv68` by default. For the sake of consistency, the assembler should probably make a corresponding change.

Also, when making this change please also describe the effects in the 21.0 LLVM release notes.

quic-akaryaki added a commit to quic-akaryaki/llvm-project that referenced this issue Mar 20, 2025
Set the default processor version to v68 when the user does not specify
one in the command line. This includes changes in the LLVM backed and
linker (lld). Since lld normally sets the version based on inputs, this
change will only affect cases when there are no inputs.

Fixes llvm#127558
@quic-akaryaki quic-akaryaki added this to the LLVM 20.X Release milestone Mar 20, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Mar 20, 2025
quic-akaryaki added a commit to quic-akaryaki/llvm-project that referenced this issue Mar 21, 2025
Set the default processor version to v68 when the user does not specify
one in the command line. This includes changes in the LLVM backed and
linker (lld). Since lld normally sets the version based on inputs, this
change will only affect cases when there are no inputs.

Update tests that use llc because codegen changed between v60 and v68.
In most cases, these are ported from the downstream sources.

Fixes llvm#127558
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in LLVM Release Status Mar 22, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 22, 2025

@llvm/issue-subscribers-lld-elf

Author: Brian Cain (androm3da)

#125239 changed the compiler driver to target `hexagonv68` by default. For the sake of consistency, the assembler and linker (lld) should make a corresponding change.

Also, when making this change please also describe the effects in the 21.0 LLVM release notes.

swift-ci pushed a commit to swiftlang/llvm-project that referenced this issue Mar 27, 2025
Set the default processor version to v68 when the user does not specify
one in the command line. This includes changes in the LLVM backed and
linker (lld). Since lld normally sets the version based on inputs, this
change will only affect cases when there are no inputs.

Fixes llvm#127558

(cherry picked from commit c0b2c10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:Hexagon enhancement Improving things as opposed to bug fixing, e.g. new or missing feature lld:ELF
Projects
Development

Successfully merging a pull request may close this issue.

4 participants