Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPIR-V] Input variables should not have linkage attributes #131878

Closed
cassiebeckley opened this issue Mar 18, 2025 · 0 comments · Fixed by #132301
Closed

[SPIR-V] Input variables should not have linkage attributes #131878

cassiebeckley opened this issue Mar 18, 2025 · 0 comments · Fixed by #132301
Assignees
@cassiebeckley
Labels
backend:SPIR-V miscompilation

Comments

@cassiebeckley
Copy link
Contributor

@llvm.spv.thread.id.in.group (generated by HLSL SV_GroupThreadID), @llvm.spv.thread.id (HLSL's SV_DispatchThreadID) and other intrinsics are currently being lowered to builtin input variables with linkage attributes. This is not valid for SPIR-V shaders.
@cassiebeckley cassiebeckley mentioned this issue Mar 18, 2025
Merged
cassiebeckley added a commit to cassiebeckley/llvm-project that referenced this issue Mar 20, 2025
@cassiebeckley
[SPIR-V] Don't add linkage attributes for input variables
7818420 
Fixes llvm#131878
@cassiebeckley cassiebeckley mentioned this issue Mar 20, 2025
Merged
s-perron pushed a commit that referenced this issue Mar 21, 2025
@cassiebeckley
[SPIR-V] Don't add linkage attributes for input variables (#132301)
0f400cb 
Fixes #131878
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cassiebeckley cassiebeckley

Labels
backend:SPIR-V miscompilation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SPIR-V] Don't add linkage attributes for input variables cassiebeckley/llvm-project
3 participants
@cassiebeckley @frederick-vs-ja @llvmbot