Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm-reduce's attribute reduction should not try to remove convergent attribute if convergence tokens are in used #132695

Closed
arsenm opened this issue Mar 24, 2025 · 0 comments · Fixed by #132946
Closed

llvm-reduce's attribute reduction should not try to remove convergent attribute if convergence tokens are in used #132695

arsenm opened this issue Mar 24, 2025 · 0 comments · Fixed by #132946
Labels
llvm-reduce

Comments

@arsenm
Copy link
Contributor

arsenm commented Mar 24, 2025

The verifier will complain if convergence tokens are used in a function that is not marked convergent. The reduction should skip functions which use them
arsenm added a commit that referenced this issue Mar 25, 2025
@arsenm
llvm-reduce: Avoid removing convergent with convergence tokens
b61c3de 
Check if the intrinsics are declared in the module as an overly
conservative fix.

Fixes #132695
@arsenm arsenm mentioned this issue Mar 25, 2025
Merged
arsenm added a commit that referenced this issue Mar 28, 2025
@arsenm
llvm-reduce: Avoid removing convergent with convergence tokens (#132946)
0ed8b27 
Check if the intrinsics are declared in the module as an overly
conservative fix.

Fixes #132695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
llvm-reduce
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

llvm-reduce: Avoid removing convergent with convergence tokens llvm/llvm-project
1 participant
@arsenm