-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LLVM][PDB][Test] Fix the build #131984
[LLVM][PDB][Test] Fix the build #131984
Conversation
Fix build after 127eb39
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Build: https://lab.llvm.org/buildbot/#/builders/145/builds/5745
For convenience, this was the problem:
25.251 [2/4/1218] Building CXX object unittests/DebugInfo/PDB/CMakeFiles/DebugInfoPDBTests.dir/PDBVariantTest.cpp.o
FAILED: unittests/DebugInfo/PDB/CMakeFiles/DebugInfoPDBTests.dir/PDBVariantTest.cpp.o
ccache /home/buildbots/llvm-external-buildbots/clang.19.1.7/bin/clang++ --gcc-toolchain=/gcc-toolchain/usr -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/unittests/DebugInfo/PDB -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/llvm/unittests/DebugInfo/PDB -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/llvm/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/third-party/unittest/googletest/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/third-party/unittest/googlemock/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -MD -MT unittests/DebugInfo/PDB/CMakeFiles/DebugInfoPDBTests.dir/PDBVariantTest.cpp.o -MF unittests/DebugInfo/PDB/CMakeFiles/DebugInfoPDBTests.dir/PDBVariantTest.cpp.o.d -o unittests/DebugInfo/PDB/CMakeFiles/DebugInfoPDBTests.dir/PDBVariantTest.cpp.o -c /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/llvm/unittests/DebugInfo/PDB/PDBVariantTest.cpp
/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/llvm/unittests/DebugInfo/PDB/PDBVariantTest.cpp:40:50: error: passing no argument for the '...' parameter of a variadic macro is a C++20 extension [-Werror,-Wc++20-extensions]
40 | TYPED_TEST_SUITE(PDBVariantIntegerTest, TestTypes);
| ^
/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/third-party/unittest/googletest/include/gtest/gtest-typed-test.h:191:9: note: macro 'TYPED_TEST_SUITE' defined here
191 | #define TYPED_TEST_SUITE(CaseName, Types, ...) \
| ^
1 error generated.
@@ -37,7 +37,7 @@ using TestTypes = testing::Types<bool, int8_t, uint8_t, int16_t, uint16_t, | |||
|
|||
} // namespace | |||
|
|||
TYPED_TEST_SUITE(PDBVariantIntegerTest, TestTypes); | |||
TYPED_TEST_SUITE(PDBVariantIntegerTest, TestTypes, ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks funny to me, but it does seem to fix the warning and we have lots of code like this already (e.g.
TYPED_TEST_SUITE(BitVectorTest, BitVectorTestTypes, ); |
Hello! Sorry, it seems I broke the build in #131598
Build:
https://lab.llvm.org/buildbot/#/builders/145/builds/5745
This is a compilation fix, please take a look.