[lld] Use *Set::insert_range (NFC) #132590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenseSet, SmallPtrSet, SmallSet, SetVector, and StringSet recently gained C++23-style insert_range. This patch replaces: Dest.insert(Src.begin(), Src.end()); with: Dest.insert_range(Src);
|
@llvm/pr-subscribers-lld-wasm @llvm/pr-subscribers-lld-elf Author: Kazu Hirata (kazutakahirata) ChangesDenseSet, SmallPtrSet, SmallSet, SetVector, and StringSet recently Dest.insert(Src.begin(), Src.end()); with: Dest.insert_range(Src); Full diff: https://github.com/llvm/llvm-project/pull/132590.diff 2 Files Affected:
diff --git a/lld/ELF/LinkerScript.cpp b/lld/ELF/LinkerScript.cpp
index 0d5b383f4b596..e19823f2ea752 100644
--- a/lld/ELF/LinkerScript.cpp
+++ b/lld/ELF/LinkerScript.cpp
@@ -797,7 +797,7 @@ void LinkerScript::processSectionCommands() {
if (!potentialSpillLists.empty()) {
DenseSet<StringRef> insertNames;
for (InsertCommand &ic : insertCommands)
- insertNames.insert(ic.names.begin(), ic.names.end());
+ insertNames.insert_range(ic.names);
for (SectionCommand *&base : sectionCommands) {
auto *osd = dyn_cast<OutputDesc>(base);
if (!osd)
diff --git a/lld/wasm/Writer.cpp b/lld/wasm/Writer.cpp
index cf315de76b4ca..f4ba182ee5079 100644
--- a/lld/wasm/Writer.cpp
+++ b/lld/wasm/Writer.cpp
@@ -588,7 +588,7 @@ void Writer::populateTargetFeatures() {
if (ctx.arg.extraFeatures.has_value()) {
auto &extraFeatures = *ctx.arg.extraFeatures;
- allowed.insert(extraFeatures.begin(), extraFeatures.end());
+ allowed.insert_range(extraFeatures);
}
// Only infer used features if user did not specify features
@@ -596,7 +596,7 @@ void Writer::populateTargetFeatures() {
if (!inferFeatures) {
auto &explicitFeatures = *ctx.arg.features;
- allowed.insert(explicitFeatures.begin(), explicitFeatures.end());
+ allowed.insert_range(explicitFeatures);
if (!ctx.arg.checkFeatures)
goto done;
}
|
MaskRay
approved these changes
Mar 23, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/18707 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DenseSet, SmallPtrSet, SmallSet, SetVector, and StringSet recently
gained C++23-style insert_range. This patch replaces:
Dest.insert(Src.begin(), Src.end());
with:
Dest.insert_range(Src);