Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc++] Implement views::join_with #65536

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

[libc++] Implement views::join_with #65536

wants to merge 46 commits into from
+5,845 −53

Conversation

JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Sep 6, 2023 •
edited
Loading

@github-actions github-actions bot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Sep 6, 2023
@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch 5 times, most recently from 3259db4 to 0481670 Compare September 8, 2023 00:07
@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch from 0481670 to f113229 Compare September 8, 2023 15:11
@ldionne ldionne assigned var-const and huixie90 and unassigned var-const Sep 13, 2023
@ldionne ldionne requested a review from huixie90 September 15, 2023 20:55
@ldionne
Copy link
Member

ldionne commented Sep 15, 2023

@JMazurkiewicz Please ping us when this is ready to review and make it a non-draft.

@philnik777 philnik777 added the ranges Issues related to `<ranges>` label Oct 6, 2023
@JMazurkiewicz JMazurkiewicz mentioned this pull request Oct 24, 2023
Merged
ldionne pushed a commit that referenced this pull request Oct 24, 2023
@JMazurkiewicz
[libc++] Update status of P2770R0, P2441R2 and P2711R1 (#70045)
e1e0598 
This patch adds a mention that the following papers are in progress:

* P2770R0: #66033
* P2441R2 and P2711R1: #65536
@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch from f113229 to 1835f68 Compare February 2, 2024 23:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2024 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@JMazurkiewicz JMazurkiewicz marked this pull request as ready for review February 4, 2024 14:58
@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner February 4, 2024 14:58
@H-G-Hristov
Copy link
Contributor

H-G-Hristov commented May 10, 2024 •
edited
Loading

I guess with constexpr variant this cool feature can be finalized now :)

@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch 3 times, most recently from a84985a to fcdf64a Compare May 14, 2024 14:38
@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch 3 times, most recently from 54a741c to a9a1031 Compare May 22, 2024 23:17
@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch from a9a1031 to 9406093 Compare June 5, 2024 09:49
@JMazurkiewicz
Remove empty test_end function
fb5ab01 
Comment: llvm#65536 (comment)
@JMazurkiewicz
Test explicitness of default constructor of join_with_view
4ab1ee2 
Comment: llvm#65536 (comment)
@JMazurkiewicz
Test explicitness of join_with_view::iterator(iterator<!Const>) con…
bf1eeac 
…structor

Comment: llvm#65536 (comment)
@JMazurkiewicz
Test explicitness of default constructor of join_with_view::iterator
3771be9 
Comment: llvm#65536 (comment)
@JMazurkiewicz
Parametrise test_pre_increment on ref-is-glvalue being true or …
04942c0 
…`false`

Comment: llvm#65536 (comment)
@JMazurkiewicz
Add extra test for iter_move (make sure it calls underlying `iter_m…
42ce9c2 
…ove`)

Comment: llvm#65536 (comment)
@JMazurkiewicz
Remove GCC workaround from increment.pass.cpp
21896e9
@JMazurkiewicz
Add extra test for iter_swap (make sure it calls underlying `iter_s…
19e4fa2 
…wap`)

Comment: llvm#65536 (comment)
@JMazurkiewicz
Make sure CIter and Iter are different types (`ctor.not_const.pas…
14471bc 
…s.cpp`)

Comment: llvm#65536 (comment)
@JMazurkiewicz
Make sure CIter and Iter are different types (eq.pass.cpp)
52ad025 
Comment: llvm#65536 (comment)
@JMazurkiewicz
Make sure CSent and Sent are different types (`ctor.not_const.pas…
d52bdbf 
…s.cpp`)

Comment: llvm#65536 (comment)
@JMazurkiewicz
Make sure CSent and Sent are different types (eq.pass.cpp)
96eae0b 
Comment: llvm#65536 (comment)
Drive-by: make use of new aliases
@JMazurkiewicz
Add missing <array> include in iter_swap.pass.cpp
0dc76bb
@JMazurkiewicz
Fix sentinel::operator==
9760ec3 
Comment: llvm#65536 (comment)
@JMazurkiewicz
Merge remote-tracking branch 'upstream/main' into libcxx/ranges/join_…
8ebaa0c 
…with
@JMazurkiewicz
Fix formatting
d9d0033
@JMazurkiewicz
Clarify some comments in test_post_increment
d3c014f
@Zingam
Copy link
Contributor

Zingam commented Jan 18, 2025

@JMazurkiewicz At the top you mention that this PR completed several papers. Do you need to add additional GitHub issues to the list that this PR closes/fixes/?

@JMazurkiewicz
Use _LIBCPP_NODEBUG attribute
abe8ab9
@JMazurkiewicz
Merge remote-tracking branch 'upstream/main' into libcxx/ranges/join_…
4972ccc 
…with
@JMazurkiewicz
[NFC] Use // REQUIRES: std-at-least-c++23
4601812 
Instead of `// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20`
@JMazurkiewicz
More _LIBCPP_NODEBUG
9847c22
@JMazurkiewicz
Fix unstable ABI tests
6a4a0a4
@JMazurkiewicz
Merge remote-tracking branch 'upstream/main' into libcxx/ranges/join_…
dfe5543 
…with
@JMazurkiewicz
Target LLVM 21
60264b0
@JMazurkiewicz
Trigger CI due to GitHub "incident"
36861f1 
https://www.githubstatus.com/incidents/nm83zrdky73y
@JMazurkiewicz
Merge remote-tracking branch 'upstream/main' into libcxx/ranges/join_…
966b3bb 
…with
@JMazurkiewicz
Add links to GitHub in 21.rst
3d54775
@JMazurkiewicz
Merge remote-tracking branch 'upstream/main' into libcxx/ranges/join_…
10fdb29 
…with
@JMazurkiewicz
Merge remote-tracking branch 'upstream/main' into libcxx/ranges/join_…
30d02a1 
…with
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zingam Zingam

@frederick-vs-ja frederick-vs-ja

@huixie90 huixie90

Assignees

@huixie90 huixie90

Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. ranges Issues related to `<ranges>`
Projects
None yet
Milestone
No milestone
8 participants
@JMazurkiewicz @ldionne @H-G-Hristov @Zingam @frederick-vs-ja @huixie90 @var-const @philnik777