Skip to content

[BOLT] Mark build skipped when tests did not run #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: users/paschalis-mpeis/increase-test-coverage
Choose a base branch
from

Conversation

paschalis-mpeis
Copy link
Member

If in-tree tests do not run, mark the whole build as skipped. Note that when this happens, out-of-tree tests also do not run.

This helps when navigating Buildbot's build requests:

  • Skipped builds indicate the change was unrelated to BOLT.
  • Any other errors are still reported.
  • For breaking changes that need reversal, builds will show as SKIPPED or FAILURE depending on whether llvm-bolt was affected, instead of SUCCESS or FAILURE, which can be confusing.

@paschalis-mpeis
Copy link
Member Author

paschalis-mpeis commented Jun 10, 2025

This PR aims to make navigating completed build requests more efficient, and less confusing. Note that the WARNINGS won't be displayed once these patches are merged (see discourse post).

An updated table with example patches after this feature:

# PATCH CODE CHANGE In-Tree Out-Of-Tree Build Status
1 e24d86 Modifies only a BOLT test. Draft Draft Draft
2 6090c0 Modifies only a BOLT test. Draft Draft Draft
3 b037d0 Modifies bolt heatmap docs. Draft Draft Draft
4 7a688c Modifies LLVM: an unsupported backend (ARM). Draft Draft Draft
5 3a9893 Modifies LLVM: a supported backend (AArch64). Draft Draft Draft
6 SHAs that fulfill next column → when nfc-check-setup was somehow broken Draft (unconditionally) Draft (unconditionally) Draft or Draft if more serious
7 SHAs before both #463 and #142410 get merged when nfc-check-validation is failing (ie unique ids embedded in binaries) Draft (unconditionally, as it thinks binaries are different. comparison is flawed though) Draft (unconditionally, as it thinks binaries are different. comparison is flawed though) Draft or Draft if more serious

@paschalis-mpeis paschalis-mpeis marked this pull request as ready for review June 10, 2025 15:54
@paschalis-mpeis paschalis-mpeis requested a review from aaupov June 10, 2025 15:54
@paschalis-mpeis paschalis-mpeis force-pushed the users/paschalis-mpeis/increase-test-coverage branch from 8f4aaf1 to 326abf3 Compare June 13, 2025 09:57
@paschalis-mpeis paschalis-mpeis force-pushed the users/paschalis-mpeis/boltbuilder-marks-build-skipped branch from 653cf9c to 05f5a8b Compare June 16, 2025 09:18
Copy link
Contributor

@aaupov aaupov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert in buildbot infra, looks good overall. Approving to unblock. Please wait a couple of days for other inputs before merging.
cc @gkistanova

@paschalis-mpeis paschalis-mpeis force-pushed the users/paschalis-mpeis/increase-test-coverage branch from 68cc918 to a16e2be Compare June 18, 2025 10:00
If in-tree tests do not run, mark the whole build as skipped. Note
that when this happens, out-of-tree tests also do not run.

This helps when navigating Buildbot's build requests:
- Skipped builds indicate the change was unrelated to BOLT.
- Any other errors are still reported.
- For breaking changes that need reversal, builds will show as
  SKIPPED or FAILURE depending on whether llvm-bolt was affected,
  instead of SUCCESS or FAILURE, which can be confusing.
@paschalis-mpeis paschalis-mpeis force-pushed the users/paschalis-mpeis/boltbuilder-marks-build-skipped branch from 05f5a8b to 04d1f0c Compare June 18, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants