Do not run "check-runtimes" if "check-all" will be also be run #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a long time, at least since llvm/llvm-project@f39a971, the runtimes tests have been part of check-all. I only noticed this the other day when our bot failed the same test twice. https://lab.llvm.org/buildbot/#/builders/161/builds/6483 The same thing happened on some ppc bots: https://lab.llvm.org/buildbot/#/builders/145/builds/7641 https://lab.llvm.org/buildbot/#/builders/95/builds/14342 This is because they run the targets separately: ninja check-all ninja check-runtimes So I have removed the check-runtimes target from these. clang-ppc64le-linux-multistage didn't run the test twice: https://lab.llvm.org/buildbot/#/builders/76/builds/10353 (twice per stage that is) Because it runs the tests as: ninja check-all check-runtimes And ninja knows that one is part of the other. I've removed check-runtimes from that bot anyway, just for clarity. The tests will still be run as part of check-all.
|
Emailed the PowerPC folks to get their feedback. |
|
On a side note can you confirm if we are running check flang-rt as part of check-all for flang bots. |
|
We are. clang-aarch64-sve-vla for example: |
|
IIRC there used to be a historical bug that this worked around, where some of the compiler-rt tests weren't run under check-all, but I don't think that is even working anymore as I don't see the edit: created a separate issue to track the builtins problem llvm/llvm-project#144090, I think that's a separate problem |
|
I'll hold off on landing this until we at least have ideas about fixing builtins. The extra testing isn't taking that much time and is better than losing coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time, at least since llvm/llvm-project@f39a971, the runtimes tests have been part of check-all.
I only noticed this the other day when our bot failed the same test twice.
https://lab.llvm.org/buildbot/#/builders/161/builds/6483
The same thing happened on some ppc bots:
https://lab.llvm.org/buildbot/#/builders/145/builds/7641 https://lab.llvm.org/buildbot/#/builders/95/builds/14342
This is because they run the targets separately:
ninja check-all
ninja check-runtimes
So I have removed the check-runtimes target from these.
clang-ppc64le-linux-multistage didn't run the test twice: https://lab.llvm.org/buildbot/#/builders/76/builds/10353
(twice per stage that is)
Because it runs the tests as: ninja check-all check-runtimes
And ninja knows that one is part of the other.
I've removed check-runtimes from that bot anyway, just for clarity. The tests will still be run as part of check-all.