[llvm-zorg] First attempt to set up libc++ runner sets. #474
Conversation
This probably needs a lot of work.
|
There's probably a lot I've done wrong -- I'm considering this a learning exercise... |
Updates the way to get the image version out of the other yaml file.
|
|
||
| node_config { | ||
| machine_type = var.linux_machine_type | ||
| taint { |
There was a problem hiding this comment.
We probably want an additional taint here specifying that this is specifically the libcxx node pool so that other jobs don't schedule here.
We could also rename the taints for the existing node pools to be specific to the main premerge system and then make this one specific to libcxx.
premerge/gke_cluster/main.tf
Outdated
| } | ||
|
|
||
| node_config { | ||
| machine_type = var.linux_machine_type |
There was a problem hiding this comment.
We probably want to change this to a different parameter specific to the libcxx jobs given we want to use a smaller machine shape.
| chart = "gha-runner-scale-set" | ||
|
|
||
| values = [ | ||
| "${templatefile("libcxx_runners_values.yaml", { runner_group_name : var.runner_group_name })}" |
There was a problem hiding this comment.
You should be able to pull the container from libcxx_image_values.yaml here too and templatize it. That would also mean we only need one runner_values.yaml for all three configurations.
premerge/premerge_resources/main.tf
Outdated
| @@ -40,10 +64,55 @@ resource "kubernetes_secret" "linux_github_pat" { | |||
| depends_on = [kubernetes_namespace.llvm_premerge_linux_runners] | |||
| } | |||
|
|
|||
| resource "kubernetes_namespace" "llvm_premerge_windows_runners" { | |||
| resource "kubernetes_secret" "libcxx_github_pat" { | |||
There was a problem hiding this comment.
We shouldn't need additional tokens. We can reuse the ones we already have.
| # exactly have N cores to allocate, but N - epsilon. | ||
| # | ||
| # We also need to request sufficient memory to not get OOM killed. | ||
| requests: |
There was a problem hiding this comment.
This need to be updated based on the new machine shape.
- Create new var, libcxx_machine_type (currently identical to linux_machine_type) and use it where appropriate. - Remove new kubernetes secrets "libcxx_github_pat", "libcxx_release_github_pat", and "libcxx_next_github_pat"; replace uses of them with "linux_github_pat".
This probably needs a lot of work.