Skip to content

Commit c756bf3

Browse files
committedJan 21, 2019
Fix bin/accountadmin when not making changes
Summary: If you go through the `accountadmin` flow and change nothing, you get an exception about the transaction not having any effect. Instead, let the `applyTransactions` call continue even on no effect. Test Plan: Ran `accountadmin` without changing anything for an existing user. No longer got an exception about no-effect transactions. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D20009
1 parent 6138d58 commit c756bf3

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed
 

‎scripts/user/account_admin.php

+1
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,7 @@
218218
->setActor($actor)
219219
->setActingAsPHID($people_application_phid)
220220
->setContentSource($content_source)
221+
->setContinueOnNoEffect(true)
221222
->setContinueOnMissingFields(true);
222223

223224
$transaction_editor->applyTransactions($user, $xactions);

0 commit comments

Comments
 (0)
Failed to load comments.