Skip to content

Commit a0cd413

Browse files
committed
[TextAPI] Teach TextAPI about arm64e
Reviewers: ributzka, cishida Subscribers: kristof.beyls, dexonsmith, dcoughlin, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75688
1 parent eae228a commit a0cd413

File tree

3 files changed

+48
-0
lines changed

3 files changed

+48
-0
lines changed

llvm/include/llvm/TextAPI/MachO/Architecture.def

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,3 +36,4 @@ ARCHINFO(armv7em, MachO::CPU_TYPE_ARM, MachO::CPU_SUBTYPE_ARM_V7EM)
3636
/// ARM64 architectures sorted by cpu sub type id.
3737
///
3838
ARCHINFO(arm64, MachO::CPU_TYPE_ARM64, MachO::CPU_SUBTYPE_ARM64_ALL)
39+
ARCHINFO(arm64e, MachO::CPU_TYPE_ARM64, MachO::CPU_SUBTYPE_ARM64E)

llvm/unittests/TextAPI/TextStubV3Tests.cpp

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -408,6 +408,31 @@ TEST(TBDv3, Platform_tvOSSim) {
408408
stripWhitespace(Buffer.c_str()));
409409
}
410410

411+
TEST(TBDv3, Arch_arm64e) {
412+
static const char TBDv3ArchArm64e[] = "--- !tapi-tbd-v3\n"
413+
"archs: [ arm64, arm64e ]\n"
414+
"platform: ios\n"
415+
"install-name: Test.dylib\n"
416+
"...\n";
417+
418+
auto Result =
419+
TextAPIReader::get(MemoryBufferRef(TBDv3ArchArm64e, "Test.tbd"));
420+
EXPECT_TRUE(!!Result);
421+
auto File = std::move(Result.get());
422+
auto Platform = PlatformKind::iOS;
423+
auto Archs = AK_arm64 | AK_arm64e;
424+
EXPECT_EQ(FileType::TBD_V3, File->getFileType());
425+
EXPECT_EQ(File->getPlatforms().size(), 1U);
426+
EXPECT_EQ(Platform, *File->getPlatforms().begin());
427+
EXPECT_EQ(Archs, File->getArchitectures());
428+
429+
SmallString<4096> Buffer;
430+
raw_svector_ostream OS(Buffer);
431+
auto WriteResult = TextAPIWriter::writeToStream(OS, *File);
432+
EXPECT_TRUE(!WriteResult);
433+
EXPECT_EQ(stripWhitespace(TBDv3ArchArm64e), stripWhitespace(Buffer.c_str()));
434+
}
435+
411436
TEST(TBDv3, Swift_1_0) {
412437
static const char TBDv3Swift1[] = "--- !tapi-tbd-v3\n"
413438
"archs: [ arm64 ]\n"

llvm/unittests/TextAPI/TextStubV4Tests.cpp

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -375,6 +375,28 @@ TEST(TBDv4, Target_arm_bridgeOS) {
375375
stripWhitespace(Buffer.c_str()));
376376
}
377377

378+
TEST(TBDv4, Target_arm_iOS) {
379+
static const char tbdv4_arm64e[] = "--- !tapi-tbd\n"
380+
"tbd-version: 4\n"
381+
"targets: [ arm64e-ios ]\n"
382+
"install-name: Test.dylib\n"
383+
"...\n";
384+
385+
auto Result = TextAPIReader::get(MemoryBufferRef(tbdv4_arm64e, "Test.tbd"));
386+
EXPECT_TRUE(!!Result);
387+
auto File = std::move(Result.get());
388+
EXPECT_EQ(FileType::TBD_V4, File->getFileType());
389+
EXPECT_EQ(File->getPlatforms().size(), 1U);
390+
EXPECT_EQ(PlatformKind::iOS, *File->getPlatforms().begin());
391+
EXPECT_EQ(ArchitectureSet(AK_arm64e), File->getArchitectures());
392+
393+
SmallString<4096> Buffer;
394+
raw_svector_ostream OS(Buffer);
395+
auto WriteResult = TextAPIWriter::writeToStream(OS, *File);
396+
EXPECT_TRUE(!WriteResult);
397+
EXPECT_EQ(stripWhitespace(tbdv4_arm64e), stripWhitespace(Buffer.c_str()));
398+
}
399+
378400
TEST(TBDv4, Target_x86_macos) {
379401
static const char tbd_x86_macos[] = "--- !tapi-tbd\n"
380402
"tbd-version: 4\n"

0 commit comments

Comments
 (0)