Fix an issue where email for "accepted" revisions would fatal

Summary: When trying to render "BRANCH", we need the active diff. Load it
in general since it seems reasonable for custom fields to expect it to
exist during mail rendering.

Author: epriestley

src/applications/differential/editor/DifferentialTransactionEditor.php

@@ -587,6 +587,7 @@ protected function applyFinalEffects(
     $new_revision = id(new DifferentialRevisionQuery())
       ->setViewer($this->getActor())
       ->needReviewerStatus(true)
+      ->needActiveDiffs(true)
       ->withIDs(array($object->getID()))
       ->executeOne();
     if (!$new_revision) {
@@ -595,6 +596,7 @@ protected function applyFinalEffects(
     }
 
     $object->attachReviewerStatus($new_revision->getReviewerStatus());
+    $object->attachActiveDiff($new_revision->getActiveDiff());
 
     foreach ($xactions as $xaction) {
       switch ($xaction->getTransactionType()) {