Remove quick create buttons from application launcher

Summary: Ref T3623. These are obsoleted by the global quick-create menu, so we can simplify the app launcher.

Test Plan: Looked at app launcher, grepped for everything.

Reviewers: chad

Reviewed By: chad

CC: chad, aran

Maniphest Tasks: T3623

Differential Revision: https://secure.phabricator.com/D8104

Author: epriestley

resources/celerity/map.php

@@ -7,7 +7,7 @@
 return array(
   'names' =>
   array(
-    'core.pkg.css' => 'a2b5fd6a',
+    'core.pkg.css' => '9ed733e4',
     'core.pkg.js' => 'c7854cc5',
     'darkconsole.pkg.js' => 'ca8671ce',
     'differential.pkg.css' => '5a65a762',
@@ -41,7 +41,7 @@
     'rsrc/css/application/auth/auth.css' => '1e655982',
     'rsrc/css/application/base/main-menu-view.css' => 'aa18107a',
     'rsrc/css/application/base/notification-menu.css' => 'fc9a363c',
-    'rsrc/css/application/base/phabricator-application-launch-view.css' => '6f8453d9',
+    'rsrc/css/application/base/phabricator-application-launch-view.css' => 'd2b2916f',
     'rsrc/css/application/base/standard-page-view.css' => '517cdfb1',
     'rsrc/css/application/chatlog/chatlog.css' => '0cd2bc78',
     'rsrc/css/application/config/config-options.css' => '7fedf08b',
@@ -670,7 +670,7 @@
     'people-profile-css' => 'd0bababe',
     'phabricator-action-header-view-css' => 'cc654b91',
     'phabricator-action-list-view-css' => '81383e25',
-    'phabricator-application-launch-view-css' => '6f8453d9',
+    'phabricator-application-launch-view-css' => 'd2b2916f',
     'phabricator-busy' => '6453c869',
     'phabricator-chatlog-css' => '0cd2bc78',
     'phabricator-content-source-view-css' => '4b8b05d4',

src/applications/base/PhabricatorApplication.php

@@ -275,18 +275,6 @@ public function buildMainMenuExtraNodes(
   }
 
 
-  /**
-   * On the Phabricator homepage sidebar, this function returns the URL for
-   * a quick create X link which is displayed in the wide button only.
-   *
-   * @return string
-   * @task ui
-   */
-  public function getQuickCreateURI() {
-    return null;
-  }
-
-
   /**
    * Build items for the "quick create" menu.
    *

src/applications/calendar/application/PhabricatorApplicationCalendar.php

@@ -32,10 +32,6 @@ public function isBeta() {
     return true;
   }
 
-  public function getQuickCreateURI() {
-    return $this->getBaseURI().'status/create/';
-  }
-
   public function getRoutes() {
     return array(
       '/calendar/' => array(

src/applications/conpherence/application/PhabricatorApplicationConpherence.php

@@ -9,10 +9,6 @@ public function getBaseURI() {
     return '/conpherence/';
   }
 
-  public function getQuickCreateURI() {
-    return $this->getBaseURI().'new/';
-  }
-
   public function getShortDescription() {
     return pht('Messaging');
   }

src/applications/files/application/PhabricatorApplicationFiles.php

@@ -29,10 +29,6 @@ public function getApplicationGroup() {
     return self::GROUP_UTILITIES;
   }
 
-  public function getQuickCreateURI() {
-    return $this->getBaseURI().'upload/';
-  }
-
   public function canUninstall() {
     return false;
   }

src/applications/legalpad/application/PhabricatorApplicationLegalpad.php

@@ -29,11 +29,6 @@ public function getApplicationGroup() {
     return self::GROUP_COMMUNICATION;
   }
 
-  public function getQuickCreateURI() {
-    return $this->getBaseURI().'create/';
-  }
-
-
   public function isBeta() {
     return true;
   }

src/applications/macro/application/PhabricatorApplicationMacro.php

@@ -22,10 +22,6 @@ public function getApplicationGroup() {
     return self::GROUP_UTILITIES;
   }
 
-  public function getQuickCreateURI() {
-    return $this->getBaseURI().'create/';
-  }
-
   public function getRoutes() {
     return array(
       '/macro/' => array(

src/applications/maniphest/application/PhabricatorApplicationManiphest.php

@@ -28,10 +28,6 @@ public function getFactObjectsForAnalysis() {
     );
   }
 
-  public function getQuickCreateURI() {
-    return $this->getBaseURI().'task/create/';
-  }
-
   public function getEventListeners() {
     return array(
       new ManiphestNameIndexEventListener(),

src/applications/meta/view/PhabricatorApplicationLaunchView.php

@@ -125,31 +125,9 @@ public function render() {
           'style' => nonempty(implode('; ', $styles), null),
         ),
         '');
-
-      $classes = array();
-      if ($application->getQuickCreateURI()) {
-        $classes[] = 'phabricator-application-create-icon';
-        $classes[] = 'sprite-icons';
-        $classes[] = 'icons-new-white';
-        $plus_icon = phutil_tag(
-          'span',
-          array(
-            'class' => implode(' ', $classes),
-          ),
-          '');
-
-        $create_button = phutil_tag(
-          'a',
-          array(
-            'href' => $application->getQuickCreateURI(),
-            'class' => 'phabricator-application-launch-create',
-          ),
-          $plus_icon);
-        $classes = array();
-        $classes[] = 'application-tile-create';
-      }
     }
 
+    $classes = array();
     $classes[] = 'phabricator-application-launch-container';
     if ($this->fullWidth) {
       $classes[] = 'application-tile-full';

src/applications/paste/application/PhabricatorApplicationPaste.php

@@ -18,10 +18,6 @@ public function getApplicationGroup() {
     return self::GROUP_UTILITIES;
   }
 
-  public function getQuickCreateURI() {
-    return $this->getBaseURI().'create/';
-  }
-
   public function getRemarkupRules() {
     return array(
       new PhabricatorPasteRemarkupRule(),

webroot/rsrc/css/application/base/phabricator-application-launch-view.css

@@ -51,28 +51,6 @@ a.application-tile-full.application-tile-create {
   border-right: none;
 }
 
-.application-tile-full + .phabricator-application-launch-create {
-  float: right;
-  width: 12%;
-  height: 52px;
-  position: relative;
-  border-top: 1px solid #000;
-  border-bottom: none;
-  display: inline-block;
-  text-align: center;
-}
-
-.device-desktop a.phabricator-application-launch-create:hover {
-  background-color: #1e2225;
-  color: #fff;
-  text-decoration: none;
-}
-
-.device-desktop a.phabricator-application-launch-container:hover {
-  background-color: #1e2225;
-  text-decoration: none;
-}
-
 .phabricator-application-launch-icon {
   display: block;
   position: absolute;
@@ -82,13 +60,6 @@ a.application-tile-full.application-tile-create {
   height: 28px;
 }
 
-.phabricator-application-create-icon {
-  display: inline-block;
-  margin: 20px auto;
-  width: 14px;
-  height: 14px;
-}
-
 .application-tile-full .phabricator-application-launch-icon {
   top: 12px;
   left: 10px;
@@ -175,20 +146,3 @@ a.application-tile-full.application-tile-create {
   top: 16px;
   right: 8px;
 }
-
-.application-tile-full .phabricator-application-launch-create {
-  display: inline-block;
-  float: right;
-  background: rgb(0, 122, 255);
-  border-radius: 5px;
-  color: white;
-  font-weight: bold;
-  padding: 1px 6px 2px;
-  border: 2px solid #333;
-  font-size: 11px;
-  box-shadow: 0 0px 2px #000;
-}
-
-.phabricator-application-launch-create {
-  display: none;
-}