Add very basic UI for creating milestones and subprojects

Summary:
Ref T10010. This has a lot of UI/UX problems but I think it:

  - technically allows subproject creation;
  - technically allows milestone creation;
  - doesn't let users unwittingly destroy their installs (probably).

Test Plan:
  - Created milestones.
  - Created subprojects.
  - Created and edited normal projects.
  - Observed some reasonable interactions (e.g., you can't create milestones for a milestone or edit a superproject's members).
  - Observed plenty of silly/confusing interactions that need additional work.

{F1046657}

{F1046658}

{F1046655}

{F1046656}

{F1046654}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10010

Differential Revision: https://secure.phabricator.com/D14904

Author: epriestley

resources/celerity/map.php

@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => 'a419cf4b',
+    'core.pkg.css' => '3ea6dc33',
     'core.pkg.js' => '57dff7df',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => '2de124c9',
@@ -114,7 +114,7 @@
     'rsrc/css/font/phui-font-icon-base.css' => 'ecbbb4c2',
     'rsrc/css/layout/phabricator-filetree-view.css' => 'fccf9f82',
     'rsrc/css/layout/phabricator-hovercard-view.css' => '1239cd52',
-    'rsrc/css/layout/phabricator-side-menu-view.css' => 'bec2458e',
+    'rsrc/css/layout/phabricator-side-menu-view.css' => '91b7a42c',
     'rsrc/css/layout/phabricator-source-code-view.css' => 'cbeef983',
     'rsrc/css/phui/calendar/phui-calendar-day.css' => 'd1cf6f93',
     'rsrc/css/phui/calendar/phui-calendar-list.css' => 'c1c7f338',
@@ -762,7 +762,7 @@
     'phabricator-remarkup-css' => '7afb543c',
     'phabricator-search-results-css' => '7dea472c',
     'phabricator-shaped-request' => '7cbe244b',
-    'phabricator-side-menu-view-css' => 'bec2458e',
+    'phabricator-side-menu-view-css' => '91b7a42c',
     'phabricator-slowvote-css' => 'da0afb1b',
     'phabricator-source-code-view-css' => 'cbeef983',
     'phabricator-standard-page-view' => '3c99cdf4',

src/__phutil_library_map__.php

@@ -2855,6 +2855,7 @@
     'PhabricatorProjectIconSet' => 'applications/project/icon/PhabricatorProjectIconSet.php',
     'PhabricatorProjectInterface' => 'applications/project/interface/PhabricatorProjectInterface.php',
     'PhabricatorProjectListController' => 'applications/project/controller/PhabricatorProjectListController.php',
+    'PhabricatorProjectListView' => 'applications/project/view/PhabricatorProjectListView.php',
     'PhabricatorProjectLockController' => 'applications/project/controller/PhabricatorProjectLockController.php',
     'PhabricatorProjectLogicalAndDatasource' => 'applications/project/typeahead/PhabricatorProjectLogicalAndDatasource.php',
     'PhabricatorProjectLogicalDatasource' => 'applications/project/typeahead/PhabricatorProjectLogicalDatasource.php',
@@ -7206,6 +7207,7 @@
     'PhabricatorProjectHeraldAction' => 'HeraldAction',
     'PhabricatorProjectIconSet' => 'PhabricatorIconSet',
     'PhabricatorProjectListController' => 'PhabricatorProjectController',
+    'PhabricatorProjectListView' => 'AphrontView',
     'PhabricatorProjectLockController' => 'PhabricatorProjectController',
     'PhabricatorProjectLogicalAndDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
     'PhabricatorProjectLogicalDatasource' => 'PhabricatorTypeaheadCompositeDatasource',

src/applications/project/__tests__/PhabricatorProjectCoreTestCase.php

@@ -748,15 +748,15 @@ private function createProject(
       ->setNewValue($name);
 
     if ($parent) {
-      $xactions[] = id(new PhabricatorProjectTransaction())
-        ->setTransactionType(PhabricatorProjectTransaction::TYPE_PARENT)
-        ->setNewValue($parent->getPHID());
-    }
-
-    if ($is_milestone) {
-      $xactions[] = id(new PhabricatorProjectTransaction())
-        ->setTransactionType(PhabricatorProjectTransaction::TYPE_MILESTONE)
-        ->setNewValue(true);
+      if ($is_milestone) {
+        $xactions[] = id(new PhabricatorProjectTransaction())
+          ->setTransactionType(PhabricatorProjectTransaction::TYPE_MILESTONE)
+          ->setNewValue($parent->getPHID());
+      } else {
+        $xactions[] = id(new PhabricatorProjectTransaction())
+          ->setTransactionType(PhabricatorProjectTransaction::TYPE_PARENT)
+          ->setNewValue($parent->getPHID());
+      }
     }
 
     $this->applyTransactions($project, $user, $xactions);

src/applications/project/controller/PhabricatorProjectController.php

@@ -99,7 +99,6 @@ public function buildSideNavView($for_app = false) {
         $nav->addFilter("board/{$id}/", pht('Workboard'));
         $nav->addFilter("members/{$id}/", pht('Members'));
         $nav->addFilter("feed/{$id}/", pht('Feed'));
-        $nav->addFilter("details/{$id}/", pht('Edit Details'));
       }
       $nav->addFilter('create', pht('Create Project'));
     }
@@ -149,11 +148,29 @@ public function buildIconNavView(PhabricatorProject $project) {
 
     $nav->addIcon("feed/{$id}/", pht('Feed'), 'fa-newspaper-o');
     $nav->addIcon("members/{$id}/", pht('Members'), 'fa-group');
-    $nav->addIcon("details/{$id}/", pht('Edit Details'), 'fa-pencil');
 
     if (PhabricatorEnv::getEnvConfig('phabricator.show-prototypes')) {
-      $nav->addIcon("subprojects/{$id}/", pht('Subprojects'), 'fa-sitemap');
-      $nav->addIcon("milestones/{$id}/", pht('Milestones'), 'fa-map-marker');
+      if ($project->supportsSubprojects()) {
+        $subprojects_icon = 'fa-sitemap';
+      } else {
+        $subprojects_icon = 'fa-sitemap grey';
+      }
+
+      if ($project->supportsMilestones()) {
+        $milestones_icon = 'fa-map-marker';
+      } else {
+        $milestones_icon = 'fa-map-marker grey';
+      }
+
+      $nav->addIcon(
+        "subprojects/{$id}/",
+        pht('Subprojects'),
+        $subprojects_icon);
+
+      $nav->addIcon(
+        "milestones/{$id}/",
+        pht('Milestones'),
+        $milestones_icon);
     }
 
 
@@ -170,8 +187,8 @@ protected function buildApplicationCrumbs() {
       $ancestors[] = $project;
       foreach ($ancestors as $ancestor) {
         $crumbs->addTextCrumb(
-          $project->getName(),
-          $project->getURI());
+          $ancestor->getName(),
+          $ancestor->getURI());
       }
     }
 

src/applications/project/controller/PhabricatorProjectEditController.php

@@ -3,10 +3,111 @@
 final class PhabricatorProjectEditController
   extends PhabricatorProjectController {
 
+  private $engine;
+
+  public function setEngine(PhabricatorProjectEditEngine $engine) {
+    $this->engine = $engine;
+    return $this;
+  }
+
+  public function getEngine() {
+    return $this->engine;
+  }
+
   public function handleRequest(AphrontRequest $request) {
-    return id(new PhabricatorProjectEditEngine())
-      ->setController($this)
-      ->buildResponse();
+    $viewer = $this->getViewer();
+
+    $engine = id(new PhabricatorProjectEditEngine())
+      ->setController($this);
+
+    $this->setEngine($engine);
+
+    $id = $request->getURIData('id');
+    if (!$id) {
+      $parent_id = head($request->getArr('parent'));
+      if (!$parent_id) {
+        $parent_id = $request->getStr('parent');
+      }
+
+      if ($parent_id) {
+        $is_milestone = false;
+      } else {
+        $parent_id = head($request->getArr('milestone'));
+        if (!$parent_id) {
+          $parent_id = $request->getStr('milestone');
+        }
+        $is_milestone = true;
+      }
+
+      if ($parent_id) {
+        $query = id(new PhabricatorProjectQuery())
+          ->setViewer($viewer)
+          ->requireCapabilities(
+            array(
+              PhabricatorPolicyCapability::CAN_VIEW,
+              PhabricatorPolicyCapability::CAN_EDIT,
+            ));
+
+        if (ctype_digit($parent_id)) {
+          $query->withIDs(array($parent_id));
+        } else {
+          $query->withPHIDs(array($parent_id));
+        }
+
+        $parent = $query->executeOne();
+
+        if ($is_milestone) {
+          if (!$parent->supportsMilestones()) {
+            $cancel_uri = "/project/milestones/{$parent_id}/";
+            return $this->newDialog()
+              ->setTitle(pht('No Milestones'))
+              ->appendParagraph(
+                pht('You can not add milestones to this project.'))
+              ->addCancelButton($cancel_uri);
+          }
+          $engine->setMilestoneProject($parent);
+        } else {
+          if (!$parent->supportsSubprojects()) {
+            $cancel_uri = "/project/subprojects/{$parent_id}/";
+            return $this->newDialog()
+              ->setTitle(pht('No Subprojects'))
+              ->appendParagraph(
+                pht('You can not add subprojects to this project.'))
+              ->addCancelButton($cancel_uri);
+          }
+          $engine->setParentProject($parent);
+        }
+
+        $this->setProject($parent);
+      }
+    }
+
+    return $engine->buildResponse();
+  }
+
+  protected function buildApplicationCrumbs() {
+    $crumbs = parent::buildApplicationCrumbs();
+
+    $engine = $this->getEngine();
+    if ($engine) {
+      $parent = $engine->getParentProject();
+      if ($parent) {
+        $id = $parent->getID();
+        $crumbs->addTextCrumb(
+          pht('Subprojects'),
+          $this->getApplicationURI("subprojects/{$id}/"));
+      }
+
+      $milestone = $engine->getMilestoneProject();
+      if ($milestone) {
+        $id = $milestone->getID();
+        $crumbs->addTextCrumb(
+          pht('Milestones'),
+          $this->getApplicationURI("milestones/{$id}/"));
+      }
+    }
+
+    return $crumbs;
   }
 
 }

src/applications/project/controller/PhabricatorProjectMembersEditController.php

@@ -68,9 +68,11 @@ public function handleRequest(AphrontRequest $request) {
       $project,
       PhabricatorPolicyCapability::CAN_EDIT);
 
+    $supports_edit = $project->supportsEditMembers();
+
     $form_box = null;
     $title = pht('Add Members');
-    if ($can_edit) {
+    if ($can_edit && $supports_edit) {
       $header_name = pht('Edit Members');
       $view_uri = $this->getApplicationURI('profile/'.$project->getID().'/');
 

src/applications/project/controller/PhabricatorProjectMilestonesController.php

@@ -18,6 +18,64 @@ public function handleRequest(AphrontRequest $request) {
     $project = $this->getProject();
     $id = $project->getID();
 
+    $can_edit = PhabricatorPolicyFilter::hasCapability(
+      $viewer,
+      $project,
+      PhabricatorPolicyCapability::CAN_EDIT);
+
+    $has_support = $project->supportsMilestones();
+    if ($has_support) {
+      $milestones = id(new PhabricatorProjectQuery())
+        ->setViewer($viewer)
+        ->withParentProjectPHIDs(array($project->getPHID()))
+        ->needImages(true)
+        ->withIsMilestone(true)
+        ->setOrder('newest')
+        ->execute();
+    } else {
+      $milestones = array();
+    }
+
+    $can_create = $can_edit && $has_support;
+
+    if ($project->getHasMilestones()) {
+      $button_text = pht('Create Next Milestone');
+    } else {
+      $button_text = pht('Add Milestones');
+    }
+
+    $header = id(new PHUIHeaderView())
+      ->setHeader(pht('Milestones'))
+      ->addActionLink(
+        id(new PHUIButtonView())
+          ->setTag('a')
+          ->setHref("/project/edit/?milestone={$id}")
+          ->setIconFont('fa-plus')
+          ->setDisabled(!$can_create)
+          ->setWorkflow(!$can_create)
+          ->setText($button_text));
+
+    $box = id(new PHUIObjectBoxView())
+      ->setHeader($header);
+
+    if (!$has_support) {
+      $no_support = pht(
+        'This project is a milestone. Milestones can not have their own '.
+        'milestones.');
+
+      $info_view = id(new PHUIInfoView())
+        ->setErrors(array($no_support))
+        ->setSeverity(PHUIInfoView::SEVERITY_WARNING);
+
+      $box->setInfoView($info_view);
+    }
+
+    $box->setObjectList(
+      id(new PhabricatorProjectListView())
+        ->setUser($viewer)
+        ->setProjects($milestones)
+        ->renderList());
+
     $nav = $this->buildIconNavView($project);
     $nav->selectFilter("milestones/{$id}/");
 
@@ -27,7 +85,8 @@ public function handleRequest(AphrontRequest $request) {
     return $this->newPage()
       ->setNavigation($nav)
       ->setCrumbs($crumbs)
-      ->setTitle(array($project->getName(), pht('Milestones')));
+      ->setTitle(array($project->getName(), pht('Milestones')))
+      ->appendChild($box);
   }
 
 }

src/applications/project/controller/PhabricatorProjectSubprojectsController.php

@@ -18,6 +18,63 @@ public function handleRequest(AphrontRequest $request) {
     $project = $this->getProject();
     $id = $project->getID();
 
+    $can_edit = PhabricatorPolicyFilter::hasCapability(
+      $viewer,
+      $project,
+      PhabricatorPolicyCapability::CAN_EDIT);
+
+    $has_support = $project->supportsSubprojects();
+
+    if ($has_support) {
+      $subprojects = id(new PhabricatorProjectQuery())
+        ->setViewer($viewer)
+        ->withParentProjectPHIDs(array($project->getPHID()))
+        ->needImages(true)
+        ->withIsMilestone(false)
+        ->execute();
+    } else {
+      $subprojects = array();
+    }
+
+    $can_create = $can_edit && $has_support;
+
+    if ($project->getHasSubprojects()) {
+      $button_text = pht('Create Subproject');
+    } else {
+      $button_text = pht('Add Subprojects');
+    }
+
+    $header = id(new PHUIHeaderView())
+      ->setHeader(pht('Subprojects'))
+      ->addActionLink(
+        id(new PHUIButtonView())
+          ->setTag('a')
+          ->setHref("/project/edit/?parent={$id}")
+          ->setIconFont('fa-plus')
+          ->setDisabled(!$can_create)
+          ->setWorkflow(!$can_create)
+          ->setText($button_text));
+
+    $box = id(new PHUIObjectBoxView())
+      ->setHeader($header);
+
+    if (!$has_support) {
+      $no_support = pht(
+        'This project is a milestone. Milestones can not have subprojects.');
+
+      $info_view = id(new PHUIInfoView())
+        ->setErrors(array($no_support))
+        ->setSeverity(PHUIInfoView::SEVERITY_WARNING);
+
+      $box->setInfoView($info_view);
+    }
+
+    $box->setObjectList(
+      id(new PhabricatorProjectListView())
+        ->setUser($viewer)
+        ->setProjects($subprojects)
+        ->renderList());
+
     $nav = $this->buildIconNavView($project);
     $nav->selectFilter("subprojects/{$id}/");
 
@@ -27,7 +84,8 @@ public function handleRequest(AphrontRequest $request) {
     return $this->newPage()
       ->setNavigation($nav)
       ->setCrumbs($crumbs)
-      ->setTitle(array($project->getName(), pht('Subprojects')));
+      ->setTitle(array($project->getName(), pht('Subprojects')))
+      ->appendChild($box);
   }
 
 }