Skip to content

Commit 9baa965

Browse files
author
Chad Little
committed
[Redesign] Workboard headers / icons
Summary: Ref T8099, cleans up spacing, colors. Switched back to dropdown icon. Test Plan: test headers in workpanels, conpherence Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D13080
1 parent 2ec7cdc commit 9baa965

File tree

5 files changed

+24
-16
lines changed

5 files changed

+24
-16
lines changed

resources/celerity/map.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*/
88
return array(
99
'names' => array(
10-
'core.pkg.css' => '72f566bb',
10+
'core.pkg.css' => 'dac18977',
1111
'core.pkg.js' => 'fbf1d615',
1212
'darkconsole.pkg.js' => 'e7393ebb',
1313
'differential.pkg.css' => '7d01bee8',
@@ -134,7 +134,7 @@
134134
'rsrc/css/phui/phui-fontkit.css' => 'b664ac96',
135135
'rsrc/css/phui/phui-form-view.css' => 'a0e8f168',
136136
'rsrc/css/phui/phui-form.css' => 'f535f938',
137-
'rsrc/css/phui/phui-header-view.css' => 'd7612da3',
137+
'rsrc/css/phui/phui-header-view.css' => '7ad91dd2',
138138
'rsrc/css/phui/phui-icon.css' => '88ba9081',
139139
'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8',
140140
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
@@ -151,7 +151,7 @@
151151
'rsrc/css/phui/phui-text.css' => 'cf019f54',
152152
'rsrc/css/phui/phui-timeline-view.css' => '8eaab66c',
153153
'rsrc/css/phui/phui-workboard-view.css' => '720efdde',
154-
'rsrc/css/phui/phui-workpanel-view.css' => '015a0cab',
154+
'rsrc/css/phui/phui-workpanel-view.css' => '01b6e9c6',
155155
'rsrc/css/sprite-login.css' => 'a3526809',
156156
'rsrc/css/sprite-menu.css' => 'ab8f6356',
157157
'rsrc/css/sprite-projects.css' => 'b0d9e24f',
@@ -769,7 +769,7 @@
769769
'phui-fontkit-css' => 'b664ac96',
770770
'phui-form-css' => 'f535f938',
771771
'phui-form-view-css' => 'a0e8f168',
772-
'phui-header-view-css' => 'd7612da3',
772+
'phui-header-view-css' => '7ad91dd2',
773773
'phui-icon-view-css' => '88ba9081',
774774
'phui-image-mask-css' => '5a8b09c8',
775775
'phui-info-panel-css' => '27ea50a1',
@@ -787,7 +787,7 @@
787787
'phui-text-css' => 'cf019f54',
788788
'phui-timeline-view-css' => '8eaab66c',
789789
'phui-workboard-view-css' => '720efdde',
790-
'phui-workpanel-view-css' => '015a0cab',
790+
'phui-workpanel-view-css' => '01b6e9c6',
791791
'phuix-action-list-view' => 'b5c256b8',
792792
'phuix-action-view' => '8cf6d262',
793793
'phuix-dropdown-menu' => 'bd4c8dca',

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -678,7 +678,7 @@ private function buildColumnMenu(
678678
}
679679

680680
$column_button = id(new PHUIIconView())
681-
->setIconFont('fa-gear')
681+
->setIconFont('fa-caret-down')
682682
->setHref('#')
683683
->addSigil('boards-dropdown-menu')
684684
->setMetadata(

src/view/phui/PHUIHeaderView.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ protected function getTagContent() {
204204
$action_list[] = phutil_tag(
205205
'li',
206206
array(
207-
'class' => 'phui-header-list-icon',
207+
'class' => 'phui-header-action-icon',
208208
),
209209
$icon);
210210
}
@@ -213,14 +213,14 @@ protected function getTagContent() {
213213
$action_list[] = phutil_tag(
214214
'li',
215215
array(
216-
'class' => 'phui-header-list-icon phui-header-tags',
216+
'class' => 'phui-header-action-tag',
217217
),
218218
array_interleave(' ', $this->tags));
219219
}
220220
$right[] = phutil_tag(
221221
'ul',
222222
array(
223-
'class' => 'phui-header-icon-list',
223+
'class' => 'phui-header-action-list',
224224
),
225225
$action_list);
226226
}

webroot/rsrc/css/phui/phui-header-view.css

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -180,15 +180,22 @@ body .phui-header-shell.phui-bleed-header
180180
display: inline-block;
181181
}
182182

183-
.phui-header-icon-list {
183+
.phui-header-action-list {
184184
float: right;
185185
}
186186

187-
.phui-header-icon-list .phui-header-list-icon {
188-
margin: 0 4px;
187+
.phui-header-action-list li {
188+
margin: 0 0 0 8px;
189189
float: right;
190190
}
191191

192-
.phui-header-icon-list .phui-header-list-icon .phui-icon-view {
193-
font-size: 15px;
192+
.phui-header-action-list li.phui-header-action-icon {
193+
height: 18px;
194+
width: 16px;
195+
}
196+
197+
.phui-header-action-list .phui-header-action-icon .phui-icon-view {
198+
font-size: 16px;
199+
line-height: 20px;
200+
display: block;
194201
}

webroot/rsrc/css/phui/phui-workpanel-view.css

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,12 @@
77
border-top-left-radius: 3px;
88
border-top-right-radius: 3px;
99
background-color: #fff;
10+
padding: 8px;
1011
}
1112

12-
.phui-workpanel-view .phui-header-shell {
13-
padding: 8px;
13+
.phui-workpanel-view .phui-header-shell .phui-header-view {
1414
font-size: 14px;
15+
color: {$darkbluetext};
1516
}
1617

1718
.phui-workpanel-view .phui-header-shell .phui-header-subheader {

0 commit comments

Comments
 (0)