Skip to content

Commit b596d85

Browse files
author
epriestley
committed
Fix one more call to addExtraQuicksandConfig()
Summary: Fixes T9881. This one had Quicksand spelled as "QuickSand" (with capital "S") so it probably didn't get hit by `grep`. Didn't need to do any special magic with the footer, as far as I can tell. Test Plan: Loaded project board view, seemed to work OK (no footer, nav works, title works, mobile menu sane). Reviewers: chad Reviewed By: chad Maniphest Tasks: T9881 Differential Revision: https://secure.phabricator.com/D14626
1 parent 7164606 commit b596d85

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,6 @@ public function handleRequest(AphrontRequest $request) {
282282
$this->initBehavior(
283283
'project-boards',
284284
$behavior_config);
285-
$this->addExtraQuickSandConfig(array('boardConfig' => $behavior_config));
286285

287286
$this->handles = ManiphestTaskListView::loadTaskHandles($viewer, $tasks);
288287

@@ -386,16 +385,21 @@ public function handleRequest(AphrontRequest $request) {
386385
->addClass('project-board-wrapper');
387386

388387
$nav = $this->buildIconNavView($project);
389-
$nav->appendChild($header_box);
390-
$nav->appendChild($board_box);
391388

392-
return $this->buildApplicationPage(
393-
$nav,
394-
array(
395-
'title' => pht('%s Board', $project->getName()),
396-
'showFooter' => false,
397-
'pageObjects' => array($project->getPHID()),
398-
));
389+
return $this->newPage()
390+
->setTitle(pht('%s Board', $project->getName()))
391+
->setPageObjectPHIDs(array($project->getPHID()))
392+
->setShowFooter(false)
393+
->setNavigation($nav)
394+
->addQuicksandConfig(
395+
array(
396+
'boardConfig' => $behavior_config,
397+
))
398+
->appendChild(
399+
array(
400+
$header_box,
401+
$board_box,
402+
));
399403
}
400404

401405
private function buildSortMenu(

0 commit comments

Comments
 (0)