Skip to content

Commit be14f75

Browse files
author
epriestley
committed
Update various hard-coded URIs
Summary: Fixes T7918. Update hard-coded ApplicationSearch URIs for parameterized typeaheads. Test Plan: Found all these links and clicked 'em. Probably. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7918 Differential Revision: https://secure.phabricator.com/D12554
1 parent 0ae08b3 commit be14f75

File tree

4 files changed

+7
-11
lines changed

4 files changed

+7
-11
lines changed

src/applications/home/controller/PhabricatorHomeMainController.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,7 @@ private function buildUnbreakNowPanel() {
148148
}
149149

150150
$href = urisprintf(
151-
'/maniphest/?statuses=%s&priorities=%s#R',
152-
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
151+
'/maniphest/?statuses=open()&priorities=%s#R',
153152
$unbreak_now);
154153
$title = pht('Unbreak Now!');
155154
$panel = new PHUIObjectBoxView();
@@ -199,8 +198,7 @@ private function buildNeedsTriagePanel(array $projects) {
199198

200199
$title = pht('Needs Triage');
201200
$href = urisprintf(
202-
'/maniphest/?statuses=%s&priorities=%s&userProjects=%s#R',
203-
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
201+
'/maniphest/?statuses=open()&priorities=%s&projects=projects(%s)#R',
204202
$needs_triage,
205203
$user->getPHID());
206204
$panel = new PHUIObjectBoxView();
@@ -290,7 +288,7 @@ private function buildTasksPanel() {
290288
}
291289

292290
$title = pht('Assigned Tasks');
293-
$href = '/maniphest';
291+
$href = '/maniphest/query/assigned/';
294292
$panel = new PHUIObjectBoxView();
295293
$panel->setHeader($this->renderSectionHeader($title, $href));
296294
$panel->appendChild($this->buildTaskListView($tasks));

src/applications/maniphest/controller/ManiphestReportController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ public function renderOpenTasks() {
465465
}
466466
}
467467

468-
$base_link = '/maniphest/?allProjects=';
468+
$base_link = '/maniphest/?projects=';
469469
$leftover_name = phutil_tag('em', array(), pht('(No Project)'));
470470
$col_header = pht('Project');
471471
$header = pht('Open Tasks by Project and Priority (%s)', $date);

src/applications/people/controller/PhabricatorPeopleController.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,7 @@ public function buildIconNavView(PhabricatorUser $user) {
7070
if (PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) {
7171
$phid = $user->getPHID();
7272
$view_uri = sprintf(
73-
'/maniphest/?statuses=%s&assigned=%s#R',
74-
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
73+
'/maniphest/?statuses=open()&assigned=%s#R',
7574
$phid);
7675
$nav->addIcon(
7776
'maniphest', pht('Open Tasks'), 'fa-anchor', null, $view_uri);

src/applications/project/controller/PhabricatorProjectController.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,8 @@ public function buildIconNavView(PhabricatorProject $project) {
7676
if (PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) {
7777
$phid = $project->getPHID();
7878
$query_uri = urisprintf(
79-
'/maniphest/?statuses=%s&allProjects=%s#R',
80-
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
81-
$phid);
79+
'/maniphest/?statuses=open()&projects=%s#R',
80+
$phid);
8281
$nav->addIcon(null, pht('Open Tasks'), 'fa-anchor', null, $query_uri);
8382
}
8483

0 commit comments

Comments
 (0)