Skip to content

Commit e67c438

Browse files
author
epriestley
committed
Rename "Edit Column" to "Column Details"
Summary: Ref T9089. This link leads to a detail page, not an edit page, and is always visible by users with permission to see the column. Test Plan: Clicked "Column Details" with and without edit permission. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9089 Differential Revision: https://secure.phabricator.com/D14016
1 parent e9614df commit e67c438

File tree

2 files changed

+5
-17
lines changed

2 files changed

+5
-17
lines changed

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -639,15 +639,13 @@ private function buildColumnMenu(
639639
->setHref($batch_edit_uri)
640640
->setDisabled(!$can_batch_edit);
641641

642-
$edit_uri = $this->getApplicationURI(
642+
$detail_uri = $this->getApplicationURI(
643643
'board/'.$this->id.'/column/'.$column->getID().'/');
644644

645645
$column_items[] = id(new PhabricatorActionView())
646-
->setIcon('fa-pencil')
647-
->setName(pht('Edit Column'))
648-
->setHref($edit_uri)
649-
->setDisabled(!$can_edit)
650-
->setWorkflow(!$can_edit);
646+
->setIcon('fa-columns')
647+
->setName(pht('Column Details'))
648+
->setHref($detail_uri);
651649

652650
$can_hide = ($can_edit && !$column->isDefaultColumn());
653651
$hide_uri = 'board/'.$this->id.'/hide/'.$column->getID().'/';

src/applications/project/controller/PhabricatorProjectColumnDetailController.php

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ public function handleRequest(AphrontRequest $request) {
1717
->withIDs(array($project_id))
1818
->needImages(true)
1919
->executeOne();
20-
2120
if (!$project) {
2221
return new Aphront404Response();
2322
}
@@ -40,7 +39,7 @@ public function handleRequest(AphrontRequest $request) {
4039
new PhabricatorProjectColumnTransactionQuery());
4140
$timeline->setShouldTerminate(true);
4241

43-
$title = pht('%s', $column->getDisplayName());
42+
$title = $column->getDisplayName();
4443

4544
$header = $this->buildHeaderView($column);
4645
$actions = $this->buildActionView($column);
@@ -113,15 +112,6 @@ private function buildPropertyView(
113112
->setObject($column)
114113
->setActionList($actions);
115114

116-
$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
117-
$viewer,
118-
$column);
119-
120-
$properties->addProperty(
121-
pht('Editable By'),
122-
$descriptions[PhabricatorPolicyCapability::CAN_EDIT]);
123-
124-
125115
$limit = $column->getPointLimit();
126116
$properties->addProperty(
127117
pht('Point Limit'),

0 commit comments

Comments
 (0)