Clean up some card issues

Summary:
Ref T2826.

  - Adds a min height (arbitrarily, height of the gradient; other choices are 60px [title + avatar], or 70px [title + projects + closed + avatar]).
  - Color bars 4px -> 6px.
  - Fixes profile image clipping in Firefox, etc.
  - Removes background color from avatars, for transparent GIFs and such.
  - Fixes shift-click to select tasks in views that can't be grabbed.

Test Plan: {F37535}

Reviewers: chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T2826

Differential Revision: https://secure.phabricator.com/D5436

Author: epriestley

src/__celerity_resource_map__.php

@@ -2996,7 +2996,7 @@
   ),
   'phabricator-object-item-list-view-css' =>
   array(
-    'uri' => '/res/527ed374/rsrc/css/layout/phabricator-object-item-list-view.css',
+    'uri' => '/res/c5d7eb5b/rsrc/css/layout/phabricator-object-item-list-view.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -3694,7 +3694,7 @@
 ), array(
   'packages' =>
   array(
-    '2f159460' =>
+    '5d5de6ec' =>
     array(
       'name' => 'core.pkg.css',
       'symbols' =>
@@ -3736,7 +3736,7 @@
         34 => 'phabricator-object-item-list-view-css',
         35 => 'global-drag-and-drop-css',
       ),
-      'uri' => '/res/pkg/2f159460/core.pkg.css',
+      'uri' => '/res/pkg/5d5de6ec/core.pkg.css',
       'type' => 'css',
     ),
     '95ceba95' =>
@@ -3927,16 +3927,16 @@
   'reverse' =>
   array(
     'aphront-attached-file-view-css' => '6b1fccc6',
-    'aphront-dialog-view-css' => '2f159460',
-    'aphront-error-view-css' => '2f159460',
-    'aphront-form-view-css' => '2f159460',
-    'aphront-list-filter-view-css' => '2f159460',
-    'aphront-pager-view-css' => '2f159460',
-    'aphront-panel-view-css' => '2f159460',
-    'aphront-table-view-css' => '2f159460',
-    'aphront-tokenizer-control-css' => '2f159460',
-    'aphront-tooltip-css' => '2f159460',
-    'aphront-typeahead-control-css' => '2f159460',
+    'aphront-dialog-view-css' => '5d5de6ec',
+    'aphront-error-view-css' => '5d5de6ec',
+    'aphront-form-view-css' => '5d5de6ec',
+    'aphront-list-filter-view-css' => '5d5de6ec',
+    'aphront-pager-view-css' => '5d5de6ec',
+    'aphront-panel-view-css' => '5d5de6ec',
+    'aphront-table-view-css' => '5d5de6ec',
+    'aphront-tokenizer-control-css' => '5d5de6ec',
+    'aphront-tooltip-css' => '5d5de6ec',
+    'aphront-typeahead-control-css' => '5d5de6ec',
     'differential-changeset-view-css' => '8aaacd1b',
     'differential-core-view-css' => '8aaacd1b',
     'differential-inline-comment-editor' => '322728f3',
@@ -3950,7 +3950,7 @@
     'differential-table-of-contents-css' => '8aaacd1b',
     'diffusion-commit-view-css' => 'c8ce2d88',
     'diffusion-icons-css' => 'c8ce2d88',
-    'global-drag-and-drop-css' => '2f159460',
+    'global-drag-and-drop-css' => '5d5de6ec',
     'inline-comment-summary-css' => '8aaacd1b',
     'javelin-aphlict' => '95ceba95',
     'javelin-behavior' => 'fe22443b',
@@ -4022,48 +4022,48 @@
     'javelin-util' => 'fe22443b',
     'javelin-vector' => 'fe22443b',
     'javelin-workflow' => 'fe22443b',
-    'lightbox-attachment-css' => '2f159460',
+    'lightbox-attachment-css' => '5d5de6ec',
     'maniphest-task-summary-css' => '6b1fccc6',
     'maniphest-transaction-detail-css' => '6b1fccc6',
     'phabricator-busy' => '95ceba95',
     'phabricator-content-source-view-css' => '8aaacd1b',
-    'phabricator-core-buttons-css' => '2f159460',
-    'phabricator-core-css' => '2f159460',
-    'phabricator-crumbs-view-css' => '2f159460',
-    'phabricator-directory-css' => '2f159460',
+    'phabricator-core-buttons-css' => '5d5de6ec',
+    'phabricator-core-css' => '5d5de6ec',
+    'phabricator-crumbs-view-css' => '5d5de6ec',
+    'phabricator-directory-css' => '5d5de6ec',
     'phabricator-drag-and-drop-file-upload' => '322728f3',
     'phabricator-dropdown-menu' => '95ceba95',
     'phabricator-file-upload' => '95ceba95',
-    'phabricator-filetree-view-css' => '2f159460',
-    'phabricator-flag-css' => '2f159460',
-    'phabricator-form-view-css' => '2f159460',
-    'phabricator-header-view-css' => '2f159460',
-    'phabricator-jump-nav' => '2f159460',
+    'phabricator-filetree-view-css' => '5d5de6ec',
+    'phabricator-flag-css' => '5d5de6ec',
+    'phabricator-form-view-css' => '5d5de6ec',
+    'phabricator-header-view-css' => '5d5de6ec',
+    'phabricator-jump-nav' => '5d5de6ec',
     'phabricator-keyboard-shortcut' => '95ceba95',
     'phabricator-keyboard-shortcut-manager' => '95ceba95',
-    'phabricator-main-menu-view' => '2f159460',
+    'phabricator-main-menu-view' => '5d5de6ec',
     'phabricator-menu-item' => '95ceba95',
-    'phabricator-nav-view-css' => '2f159460',
+    'phabricator-nav-view-css' => '5d5de6ec',
     'phabricator-notification' => '95ceba95',
-    'phabricator-notification-css' => '2f159460',
-    'phabricator-notification-menu-css' => '2f159460',
-    'phabricator-object-item-list-view-css' => '2f159460',
+    'phabricator-notification-css' => '5d5de6ec',
+    'phabricator-notification-menu-css' => '5d5de6ec',
+    'phabricator-object-item-list-view-css' => '5d5de6ec',
     'phabricator-object-selector-css' => '8aaacd1b',
     'phabricator-paste-file-upload' => '95ceba95',
     'phabricator-prefab' => '95ceba95',
     'phabricator-project-tag-css' => '6b1fccc6',
-    'phabricator-remarkup-css' => '2f159460',
+    'phabricator-remarkup-css' => '5d5de6ec',
     'phabricator-shaped-request' => '322728f3',
-    'phabricator-side-menu-view-css' => '2f159460',
-    'phabricator-standard-page-view' => '2f159460',
+    'phabricator-side-menu-view-css' => '5d5de6ec',
+    'phabricator-standard-page-view' => '5d5de6ec',
     'phabricator-textareautils' => '95ceba95',
     'phabricator-tooltip' => '95ceba95',
-    'phabricator-transaction-view-css' => '2f159460',
-    'phabricator-zindex-css' => '2f159460',
-    'sprite-apps-large-css' => '2f159460',
-    'sprite-gradient-css' => '2f159460',
-    'sprite-icon-css' => '2f159460',
-    'sprite-menu-css' => '2f159460',
-    'syntax-highlighting-css' => '2f159460',
+    'phabricator-transaction-view-css' => '5d5de6ec',
+    'phabricator-zindex-css' => '5d5de6ec',
+    'sprite-apps-large-css' => '5d5de6ec',
+    'sprite-gradient-css' => '5d5de6ec',
+    'sprite-icon-css' => '5d5de6ec',
+    'sprite-menu-css' => '5d5de6ec',
+    'syntax-highlighting-css' => '5d5de6ec',
   ),
 ));

src/applications/maniphest/view/ManiphestTaskListView.php

@@ -79,6 +79,8 @@ public function render() {
 
       if ($this->showSubpriorityControls) {
         $item->setGrippable(true);
+      }
+      if ($this->showSubpriorityControls || $this->showBatchControls) {
         $item->addSigil('maniphest-task');
       }
 

src/view/layout/PhabricatorObjectItemView.php

@@ -373,7 +373,7 @@ private function renderHandleIcon(PhabricatorObjectHandle $handle, $label) {
 
     $options = array(
       'class' => 'phabricator-object-item-handle-icon',
-      'style' => 'background: url('.$handle->getImageURI().')',
+      'style' => 'background-image: url('.$handle->getImageURI().')',
     );
 
     if (strlen($label)) {

webroot/rsrc/css/layout/phabricator-object-item-list-view.css

@@ -326,7 +326,6 @@
   width: 28px;
   height: 28px;
   display: inline-block;
-  background: #f3f3f3;
   background-size: 28px 28px;
   background-repeat: no-repeat;
 }
@@ -341,10 +340,15 @@
 /* Hard to sprite since we can't have other sprites appearing in tall cells */
 .phabricator-object-list-cards .phabricator-object-item {
   border-radius: 3px;
-  border-left-width: 4px;
+  border-left-width: 6px;
   background: #e8e8e8 url('/rsrc/image/texture/card-gradient.png') repeat-x;
 }
 
+.phabricator-object-list-cards .phabricator-object-item-frame {
+  min-height: 47px;
+}
+
+
 .phabricator-object-list-cards .phabricator-object-item-name {
   font-size: 13px;
   white-space: nowrap;