Skip to content

[webgpu] Add zero points support for dp4 path #24675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 17, 2025
Merged

[webgpu] Add zero points support for dp4 path #24675

merged 8 commits into from
Jun 17, 2025

Conversation

qjia7
Copy link
Contributor

@qjia7 qjia7 commented May 7, 2025

This PR adds the zero points support for the DP4 and subgroupMatrix path.

@qjia7 qjia7 force-pushed the zero_points_dp4 branch from c960f03 to 05f0d40 Compare May 7, 2025 08:44
@qjia7 qjia7 marked this pull request as ready for review May 7, 2025 11:16
@qjia7 qjia7 requested a review from sushraja-msft May 7, 2025 11:16
@guschmue guschmue added the ep:WebGPU ort-web webgpu provider label May 7, 2025
@qjia7 qjia7 marked this pull request as draft May 8, 2025 03:21
@qjia7 qjia7 marked this pull request as ready for review May 8, 2025 04:44
@qjia7 qjia7 requested a review from guschmue May 15, 2025 01:05
@qjia7
Copy link
Contributor Author

qjia7 commented May 15, 2025

@sushraja-msft @guschmue Please take a look, thanks.

Copy link
Contributor

@sushraja-msft sushraja-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@qjia7 qjia7 requested a review from sushraja-msft June 12, 2025 11:46
Copy link
Contributor

@guschmue guschmue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@qjia7 qjia7 merged commit 796ad45 into main Jun 17, 2025
89 checks passed
@qjia7 qjia7 deleted the zero_points_dp4 branch June 17, 2025 00:29
guschmue pushed a commit that referenced this pull request Jun 17, 2025
This PR adds the zero points support for the DP4 and subgroupMatrix
path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants