Skip to content

Commit 42e46bb

Browse files
author
epriestley
committedFeb 3, 2020
Fix an issue where Herald rules could fail to evaluate at post-commit time
Summary: Ref T13480. Some Herald fields need audit information, which recent changes to Herald adapters discarded. For now, just load it unconditionally. Test Plan: Triggered an Audit-related rule locally. Maniphest Tasks: T13480 Differential Revision: https://secure.phabricator.com/D20962
1 parent ccf28a8 commit 42e46bb

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed
 

‎src/applications/diffusion/herald/HeraldCommitAdapter.php

+1
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ public function setObject($object) {
5252
->withPHIDs(array($commit_phid))
5353
->needCommitData(true)
5454
->needIdentities(true)
55+
->needAuditRequests(true)
5556
->executeOne();
5657
if (!$commit) {
5758
throw new Exception(

0 commit comments

Comments
 (0)
Failed to load comments.