Skip to content

Commit 6d4c692

Browse files
author
epriestley
committedFeb 4, 2020
Update Herald rule creation workflow to use more modern UI elements
Summary: Ref T13480. Creating a rule in Herald currently uses the older radio-button flow. Update it to the "clickable menu" flow to simplify it a little bit. Test Plan: Created new personal, object, and global rules. Hit the object rule error conditions. Maniphest Tasks: T13480 Differential Revision: https://secure.phabricator.com/D20956
1 parent 4904d77 commit 6d4c692

File tree

5 files changed

+326
-257
lines changed

5 files changed

+326
-257
lines changed
 

‎resources/celerity/map.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
'names' => array(
1010
'conpherence.pkg.css' => '3c8a0668',
1111
'conpherence.pkg.js' => '020aebcf',
12-
'core.pkg.css' => '6d9a0ba6',
12+
'core.pkg.css' => '5edb4679',
1313
'core.pkg.js' => '705aec2c',
1414
'differential.pkg.css' => '607c84be',
1515
'differential.pkg.js' => '1b97518d',
@@ -165,7 +165,7 @@
165165
'rsrc/css/phui/phui-left-right.css' => '68513c34',
166166
'rsrc/css/phui/phui-lightbox.css' => '4ebf22da',
167167
'rsrc/css/phui/phui-list.css' => 'b05144dd',
168-
'rsrc/css/phui/phui-object-box.css' => 'f434b6be',
168+
'rsrc/css/phui/phui-object-box.css' => 'b8d7eea0',
169169
'rsrc/css/phui/phui-pager.css' => 'd022c7ad',
170170
'rsrc/css/phui/phui-pinboard-view.css' => '1f08f5d8',
171171
'rsrc/css/phui/phui-policy-section-view.css' => '139fdc64',
@@ -855,7 +855,7 @@
855855
'phui-left-right-css' => '68513c34',
856856
'phui-lightbox-css' => '4ebf22da',
857857
'phui-list-view-css' => 'b05144dd',
858-
'phui-object-box-css' => 'f434b6be',
858+
'phui-object-box-css' => 'b8d7eea0',
859859
'phui-oi-big-ui-css' => 'fa74cc35',
860860
'phui-oi-color-css' => 'b517bfa0',
861861
'phui-oi-drag-ui-css' => 'da15d3dc',

‎src/applications/herald/adapter/HeraldAdapter.php

+6
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,12 @@ abstract public function getAdapterContentDescription();
243243
abstract public function getAdapterApplicationClass();
244244
abstract public function getObject();
245245

246+
public function getAdapterContentIcon() {
247+
$application_class = $this->getAdapterApplicationClass();
248+
$application = newv($application_class, array());
249+
return $application->getIcon();
250+
}
251+
246252
/**
247253
* Return a new characteristic object for this adapter.
248254
*

0 commit comments

Comments
 (0)
Failed to load comments.