Bug 1837658 - enable Stylelint length-zero-no-unit r=frontend-codestyle-reviewers,desktop-theme-reviewers,mtigley,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,translations-reviewers,android-reviewers,backup-reviewers,nchevobbe,dao,mconley,tthibaud

This use of units for zero length occasionally gets flagged during theme reviews so it makes sense to establish our preference and automate checks via Stylelint.

Differential Revision: https://phabricator.services.mozilla.com/D230287

Author: hannajones

.stylelintrc.js

@@ -31,7 +31,6 @@ module.exports = {
   ],
   ignoreFiles,
   rules: {
-    "stylelint-plugin-mozilla/no-base-design-tokens": true,
     /* Disabled because of `-moz-element(#foo)` which gets misparsed. */
     "color-no-invalid-hex": null,
     "font-family-no-missing-generic-family-keyword": [
@@ -57,6 +56,13 @@ module.exports = {
       },
     ],
 
+    "length-zero-no-unit": [
+      true,
+      {
+        ignore: ["custom-properties"],
+      },
+    ],
+
     "max-nesting-depth": [
       3,
       {
@@ -261,6 +267,7 @@ module.exports = {
         ignorePseudoElements: ["slider-track", "slider-fill", "slider-thumb"],
       },
     ],
+    "stylelint-plugin-mozilla/no-base-design-tokens": true,
   },
 
   overrides: [

browser/components/aboutlogins/content/components/login-message-popup.css

@@ -56,6 +56,6 @@
     top: 100%;
     left: 50%;
     transform: translateX(-50%) rotate(270deg);
-    margin-top: 0px;
+    margin-top: 0;
   }
 }