Skip to content

Commit 545a730

Browse files
committedNov 13, 2017
Bug 1417264 - Move printing of mozconfig lines to Python; r=nalexander
We write the file that client.mk is printing from Python. We can also log it from there pretty easily. So do that. MozReview-Commit-ID: 7eeugdOJR5b
1 parent 4ab8156 commit 545a730

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed
 

‎client.mk

-7
Original file line numberDiff line numberDiff line change
@@ -102,13 +102,6 @@ $(OBJDIR)/.mozconfig.mk: $(TOPSRCDIR)/client.mk $(FOUND_MOZCONFIG)
102102
# from, has already been eval'ed.
103103
include $(OBJDIR)/.mozconfig.mk
104104

105-
# Print out any options loaded from mozconfig.
106-
all build clean distclean export libs install realclean::
107-
ifneq (,$(strip $(MOZCONFIG_OUT_LINES)))
108-
$(info Adding client.mk options from $(FOUND_MOZCONFIG):)
109-
$(foreach line,$(MOZCONFIG_OUT_LINES),$(info $(NULL) $(NULL) $(NULL) $(NULL) $(subst ||, ,$(line))))
110-
endif
111-
112105
# In automation, manage an sccache daemon. The starting of the server
113106
# needs to be in a make file so sccache inherits the jobserver.
114107
ifdef MOZBUILD_MANAGE_SCCACHE_DAEMON

‎python/mozbuild/mozbuild/controller/building.py

+6
Original file line numberDiff line numberDiff line change
@@ -1358,6 +1358,12 @@ def _run_client_mk(self, target=None, line_handler=None, jobs=0,
13581358
with FileAvoidWrite(mozconfig_client_mk) as fh:
13591359
fh.write(b'\n'.join(mozconfig_make_lines))
13601360

1361+
if mozconfig_make_lines:
1362+
self.log(logging.WARNING, 'mozconfig_content', {
1363+
'path': mozconfig['path'],
1364+
'content': '\n '.join(mozconfig_make_lines),
1365+
}, 'Adding make options from {path}\n {content}')
1366+
13611367
append_env['OBJDIR'] = mozpath.normsep(self.topobjdir)
13621368

13631369
return self._run_make(srcdir=True,

0 commit comments

Comments
 (0)
Failed to load comments.