Bug 1653214 - Part 2: Remove nsIBaseWindow::Create; r=nika

Differential Revision: https://phabricator.services.mozilla.com/D83767

Author: EdgarChen

docshell/base/nsDocShell.cpp

@@ -4111,13 +4111,6 @@ nsDocShell::InitWindow(nativeWindow aParentNativeWindow,
   return NS_OK;
 }
 
-NS_IMETHODIMP
-nsDocShell::Create() {
-  // Implementations have been moved to nsDocShell::Initialize
-  MOZ_DIAGNOSTIC_ASSERT(false);
-  return NS_ERROR_NULL_POINTER;
-}
-
 NS_IMETHODIMP
 nsDocShell::Destroy() {
   // XXX: We allow this function to be called just once.  If you are going to

docshell/base/nsDocShellTreeOwner.cpp

@@ -440,9 +440,6 @@ nsDocShellTreeOwner::InitWindow(nativeWindow aParentNativeWindow,
   return NS_ERROR_NULL_POINTER;
 }
 
-NS_IMETHODIMP
-nsDocShellTreeOwner::Create() { return NS_ERROR_NULL_POINTER; }
-
 NS_IMETHODIMP
 nsDocShellTreeOwner::Destroy() {
   nsCOMPtr<nsIWebBrowserChrome> webBrowserChrome = GetWebBrowserChrome();

toolkit/components/browser/nsWebBrowser.cpp

@@ -850,14 +850,6 @@ nsWebBrowser::InitWindow(nativeWindow aParentNativeWindow,
   return NS_ERROR_NULL_POINTER;
 }
 
-NS_IMETHODIMP
-nsWebBrowser::Create() {
-  // nsIBaseWindow::InitWindow and nsIBaseWindow::Create
-  // implementations have been merged into nsWebBrowser::Create
-  MOZ_DIAGNOSTIC_ASSERT(false);
-  return NS_ERROR_NULL_POINTER;
-}
-
 NS_IMETHODIMP
 nsWebBrowser::Destroy() {
   InternalDestroy();

widget/nsIBaseWindow.idl

@@ -52,27 +52,15 @@ interface nsIBaseWindow : nsISupports
 	@param cy - This is the height for the window to be.
 
 	@return	NS_OK - Window Init succeeded without a problem.
-				NS_ERROR_UNEXPECTED - Call was unexpected at this time.  Most likely
-					due to you calling it after create() has been called.
+				NS_ERROR_UNEXPECTED - Call was unexpected at this time. Perhaps
+				  initWindow() had already been called.
 				NS_ERROR_INVALID_ARG - controls that require either a parentNativeWindow
 					or a parentWidget may return invalid arg when they do not
 					receive what they are needing.
 	*/
 	[noscript]void initWindow(in nativeWindow parentNativeWindow,
 		in nsIWidget parentWidget,	in long x, in long y, in long cx, in long cy);
 
-	/*
-	Tells the window that intialization and setup is complete.  When this is
-	called the window can actually create itself based on the setup
-	information handed to it.
-
-	@return	NS_OK - Creation was successfull.
-				NS_ERROR_UNEXPECTED - This call was unexpected at this time.
-					Perhaps create() had already been called or not all
-					required initialization had been done.
-	*/
-	void create();
-
 	/*
 	Tell the window that it should destroy itself.  This call should not be
 	necessary as it will happen implictly when final release occurs on the

xpfe/appshell/AppWindow.cpp

@@ -526,12 +526,6 @@ NS_IMETHODIMP AppWindow::InitWindow(nativeWindow aParentNativeWindow,
   return NS_OK;
 }
 
-NS_IMETHODIMP AppWindow::Create() {
-  // XXX First Check In
-  NS_ASSERTION(false, "Not Yet Implemented");
-  return NS_OK;
-}
-
 NS_IMETHODIMP AppWindow::Destroy() {
   nsCOMPtr<nsIAppWindow> kungFuDeathGrip(this);
 

xpfe/appshell/nsChromeTreeOwner.cpp

@@ -250,11 +250,6 @@ NS_IMETHODIMP nsChromeTreeOwner::InitWindow(nativeWindow aParentNativeWindow,
   return NS_OK;
 }
 
-NS_IMETHODIMP nsChromeTreeOwner::Create() {
-  NS_ASSERTION(false, "You can't call this");
-  return NS_ERROR_UNEXPECTED;
-}
-
 NS_IMETHODIMP nsChromeTreeOwner::Destroy() {
   NS_ENSURE_STATE(mAppWindow);
   return mAppWindow->Destroy();

xpfe/appshell/nsContentTreeOwner.cpp

@@ -461,11 +461,6 @@ NS_IMETHODIMP nsContentTreeOwner::InitWindow(nativeWindow aParentNativeWindow,
   return NS_OK;
 }
 
-NS_IMETHODIMP nsContentTreeOwner::Create() {
-  NS_ASSERTION(false, "You can't call this");
-  return NS_ERROR_UNEXPECTED;
-}
-
 NS_IMETHODIMP nsContentTreeOwner::Destroy() {
   NS_ENSURE_STATE(mAppWindow);
   return mAppWindow->Destroy();