Skip to content

Commit c4bb3bc

Browse files
committedSep 28, 2017
Bug 1403366 - Don't set MOZILLA_FIVE_HOME from multiple scripts. r=froydnj
It was seldom used before previous commit and now does nothing.
1 parent 70d4ea6 commit c4bb3bc

File tree

6 files changed

+2
-13
lines changed

6 files changed

+2
-13
lines changed
 

‎build/automation.py.in

-1
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,6 @@ class Automation(object):
199199
envVar = "DYLD_LIBRARY_PATH"
200200
dmdLibrary = "libdmd.dylib"
201201
else: # unixish
202-
env['MOZILLA_FIVE_HOME'] = xrePath
203202
dmdLibrary = "libdmd.so"
204203
if envVar in env:
205204
ldLibraryPath = ldLibraryPath + ":" + env[envVar]

‎build/unix/run-mozilla.sh

+2-8
Original file line numberDiff line numberDiff line change
@@ -237,13 +237,8 @@ then
237237
moz_bail "Cannot execute $MOZ_PROGRAM."
238238
fi
239239
#
240-
##
241-
## Set MOZILLA_FIVE_HOME
242-
##
243-
MOZILLA_FIVE_HOME=$MOZ_DIST_BIN
244-
245240
if [ -z "$MRE_HOME" ]; then
246-
MRE_HOME=$MOZILLA_FIVE_HOME
241+
MRE_HOME=$MOZ_DIST_BIN"
247242
fi
248243
##
249244
## Set LD_LIBRARY_PATH
@@ -315,7 +310,6 @@ export GNOME_DISABLE_CRASH_DIALOG
315310
316311
if [ "$moz_debug" -eq 1 ]
317312
then
318-
echo "MOZILLA_FIVE_HOME=$MOZILLA_FIVE_HOME"
319313
echo " LD_LIBRARY_PATH=$LD_LIBRARY_PATH"
320314
if [ -n "$LD_LIBRARYN32_PATH" ]
321315
then
@@ -349,7 +343,7 @@ then
349343
echo "moz_debugger_args=$moz_debugger_args"
350344
fi
351345
#
352-
export MOZILLA_FIVE_HOME LD_LIBRARY_PATH
346+
export LD_LIBRARY_PATH
353347
export SHLIB_PATH LIBPATH LIBRARY_PATH ADDON_PATH DYLD_LIBRARY_PATH
354348
355349
if [ $moz_debug -eq 1 ]

‎testing/gtest/rungtests.py

-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ def build_core_environment(self, env = {}):
8181
"""
8282
Add environment variables likely to be used across all platforms, including remote systems.
8383
"""
84-
env["MOZILLA_FIVE_HOME"] = self.xre_path
8584
env["MOZ_XRE_DIR"] = self.xre_path
8685
env["MOZ_GMP_PATH"] = os.pathsep.join(
8786
os.path.join(self.xre_path, p, "1.0")

‎testing/mozbase/mozrunner/mozrunner/utils.py

-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ def test_environment(xrePath, env=None, crashreporter=True, debugger=False,
104104
preloadEnvVar = None
105105
if mozinfo.isUnix:
106106
envVar = "LD_LIBRARY_PATH"
107-
env['MOZILLA_FIVE_HOME'] = xrePath
108107
dmdLibrary = "libdmd.so"
109108
preloadEnvVar = "LD_PRELOAD"
110109
elif mozinfo.isMac:

‎testing/remotecppunittests.py

-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ def build_environment(self):
107107
env['LD_LIBRARY_PATH'] = self.remote_bin_dir
108108
env["TMPDIR"] = self.remote_tmp_dir
109109
env["HOME"] = self.remote_home_dir
110-
env["MOZILLA_FIVE_HOME"] = self.remote_home_dir
111110
env["MOZ_XRE_DIR"] = self.remote_bin_dir
112111
if self.options.add_env:
113112
for envdef in self.options.add_env:

‎testing/runcppunittests.py

-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ def build_core_environment(self, env={}):
8484
"""
8585
Add environment variables likely to be used across all platforms, including remote systems.
8686
"""
87-
env["MOZILLA_FIVE_HOME"] = self.xre_path
8887
env["MOZ_XRE_DIR"] = self.xre_path
8988
# TODO: switch this to just abort once all C++ unit tests have
9089
# been fixed to enable crash reporting

0 commit comments

Comments
 (0)
Failed to load comments.