Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logging and ensure that stages that use network are retried before failing. #20

Closed
wants to merge 10 commits into from

Conversation

fbessou
Copy link
Collaborator

@fbessou fbessou commented Jan 7, 2025

No description provided.

Copy link

github-actions bot commented Jan 7, 2025

Unit tests Coverage

Unit tests Coverage
FileStmtsMissCoverMissing
__init__.py00100% 
__main__.py422345%16–17, 24, 51–52, 54, 56, 62–65, 68, 72–76, 78–82, 86
application.py533533%27–30, 33–38, 40–41, 44–45, 47–48, 50–53, 57–59, 65–66, 72, 78–86
config.py41197%50
events.py190100% 
mapping.py612263%47, 60, 63–69, 72, 75, 84, 97, 100–107, 117
pulse_worker.py401562%13, 25–27, 37, 42, 45, 48–55
repo_synchronizer.py73790%43–44, 62, 64–66, 175
retry.py19289%40, 47
TOTAL34810569% 

JUnit Xml Summary

Tests Skipped Failures Errors Time
13 2 💤 0 ❌ 0 🔥 4.251s ⏱️

Copy link

github-actions bot commented Jan 7, 2025

Integration tests Coverage

Integration tests Coverage
FileStmtsMissCoverMissing
__init__.py00100% 
__main__.py421466%16–17, 24, 72–76, 78–82, 86
application.py531375%34–38, 65–66, 72, 79–81, 85–86
config.py41197%50
events.py190100% 
mapping.py61591%47, 64, 68, 101, 105
pulse_worker.py40295%13, 37
repo_synchronizer.py73790%43–44, 62, 64–66, 175
retry.py19289%40, 47
TOTAL3484487% 

JUnit Xml Summary

Tests Skipped Failures Errors Time
13 0 💤 0 ❌ 0 🔥 6.180s ⏱️

@fbessou fbessou force-pushed the retry branch 2 times, most recently from 8f4ac83 to 578b084 Compare January 8, 2025 09:20
Copy link
Collaborator

@djangoliv djangoliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@globau
Copy link
Contributor

globau commented Jan 30, 2025

As this conflicts with #21, I'll get #21 landed then fix and apply the changes from this PR (likely in a new one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants